Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding drop downs #2537

Closed

Conversation

hemu-codes
Copy link
Contributor

Fixes #2506

Description

Because the Github Repositories page contains a lot of information, adding drop-downs would make it easier for users to navigate through the page. I have tried 2 different drop-down views (with the last section having a different view). I would still need to clean up a few more things on the page but do let me know if the drop-downs are useful and which version would be more useful/cleaner.

Raw.Githack preview link

https://raw.githack.com/hemu-codes/hemu-codes.github.io/adding-drop-downs/#!pages/vi/vi-github-and-repositories.md

Copy link
Member

@lmmrssa lmmrssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemu-codes based on your initial issue, it seemed like you were just putting arrow to show that there is something link is pointing to. But looking on your changes you are completely hidding it and only making it visible when someone clicks it. This is increasing people from not seeing the content.

@hemu-codes
Copy link
Contributor Author

@lmmrssa After researching how to add drop-downs in Markdown, there was only two kinds of drop-down I could add: 1 with the details showing and the user can manually close it once they've seen and the other is shown in the following image:
Screen Shot 2019-07-15 at 11 31 30 PM

@iawale
Copy link
Contributor

iawale commented Jul 18, 2019

@lmmrssa @hemu-codes I think the first thing to do is, the drop-down-content should be shown first rather than be hidden when the page is first loaded. Also, you should consider putting the arrow right beside the heading.

@hemu-codes
Copy link
Contributor Author

@ChiragAwale I've made some changes. Could you look over it again? The trouble I'm having with adding the drop-downs is that the hyperlinks to each of the section stop working after the dropdowns are added and another issue (a smaller one) is that I have to have the section title twice because I can't format the drop-down text.

@lmmrssa
Copy link
Member

lmmrssa commented Jul 19, 2019

@hemu-codes with this changes, Link on Start here does not work. So lets not put it here.
Initial assumption was that you do not find content easily as points of Start here was not highlighted. But you are making other section highlighted.
i don't think we need expandable section on those part. It will just make it more hidden as someone might click it and then do not know it got collapsed so there is some content there.

@lmmrssa lmmrssa closed this Jul 24, 2019
Kuljeet1998 pushed a commit to Kuljeet1998/Kuljeet1998.github.io that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding drop-down feature to Git Repositories section
3 participants