Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Effect of review_duration column on weights #118

Closed
joshdavham opened this issue Jul 11, 2024 · 1 comment
Closed

Q: Effect of review_duration column on weights #118

joshdavham opened this issue Jul 11, 2024 · 1 comment

Comments

@joshdavham
Copy link
Member

joshdavham commented Jul 11, 2024

I've been experimenting a bit with the optimizer and noticed that I get the same weights regardless of whether I include the review_duration column in my revlog file.

My question: does review_duration have any effect on the resulting optimal weights? Or does it only affect requestRetention?

I'm asking this in part because I'm building some software with FSRS and am trying to figure out whether I should be including review duration in my revlogs.

Thanks!

@Expertium
Copy link
Contributor

FSRS only needs interval lengths and grades. Review duration is used for calculating optimal retention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants