From 1ed0da408fc8e3913ae04363722de5dd811fd84b Mon Sep 17 00:00:00 2001 From: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com> Date: Mon, 20 Nov 2023 15:14:01 -0500 Subject: [PATCH] syslog tests: cleanup subprocess (#29401) **Description:** Fixes a flake issue where one collector subprocess isn't torn down before the next test run: ``` 2023-11-20T19:30:42.822Z error otelcol@v0.89.0/collector.go:255 Asynchronous error received, terminating process {"error": "listen tcp :8888: bind: address already in use"} ``` **Testing:** Adds asserted case cleanup. **Documentation:** none needed --- testbed/tests/syslog_integration_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/testbed/tests/syslog_integration_test.go b/testbed/tests/syslog_integration_test.go index 04195a0105c3..49d59eb5cc8f 100644 --- a/testbed/tests/syslog_integration_test.go +++ b/testbed/tests/syslog_integration_test.go @@ -145,6 +145,12 @@ service: }) require.NoError(t, err) + t.Cleanup(func() { + stopped, e := collector.Stop() + require.NoError(t, e) + require.True(t, stopped) + }) + // prepare data message := ""