Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Clarify expectations for C++ exceptions, and usage of noexcept methods. #3013

Open
marcalff opened this issue Jul 26, 2024 · 3 comments
Labels
bug Something isn't working Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

Several methods in the API are flagged as noexcept.

This is desirable, because adding instrumentation to an application (i.e., calling opentelemetry-cpp apis) should not make the application less stable.

In particular, any failure in the opentelemetry-cpp sdk or exporters should not propagate the exception up, taking the application down.

To comply with the noexcept contract, methods in the SDK implementation should never raise exceptions.

According to clang-tidy reports, this is not always the case.

This part should be revisited, to clarify expectations, and enforce the SDK implementation complies.

cc @msiddhu

@marcalff marcalff added the bug Something isn't working label Jul 26, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 26, 2024
@marcalff
Copy link
Member Author

@msiddhu
Copy link
Contributor

msiddhu commented Jul 29, 2024

I'll work on this. Currently, there are 20 warnings flagged by clang-tidy as they may raise errors. I'll make a sheet explaining why and will come up with a cleanup. I'm busy this week but will raise a PR by late next week.

@esigo esigo added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 7, 2024
Copy link

github-actions bot commented Oct 9, 2024

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants