Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-instrumentation-aws-sdk] Add S3 Bucket Name and Kinesis Stream Name to aws-sdk span attribute if present #2360

Open
jj22ee opened this issue Jul 31, 2024 · 0 comments

Comments

@jj22ee
Copy link
Contributor

jj22ee commented Jul 31, 2024

Is your feature request related to a problem? Please describe

I created S3 (ListObjects) and Kinesis (CreateStream) Client calls, but did not observe S3 Bucket Name or Kinesis Stream Name in the respective spans that were generated for these calls.

Describe the solution you'd like to see

I want S3 Bucket Name and Kinesis Stream Name to be added to aws-sdk span attribute if present

Describe alternatives you've considered

N/A

Additional context

S3 semantic conventions: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/object-stores/s3.md
No such semantic conventions for Kinesis Streams exist in OTel JS repo, but AWS ADOT team hopes that such conventions are eventually added to upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant