Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-instrumentation-openai] Add openai sdk #2378

Open
AmanAgarwal041 opened this issue Aug 7, 2024 · 4 comments · May be fixed by #2402
Open

[opentelemetry-instrumentation-openai] Add openai sdk #2378

AmanAgarwal041 opened this issue Aug 7, 2024 · 4 comments · May be fixed by #2402

Comments

@AmanAgarwal041
Copy link

Is your instrumentation request related to a problem? Please describe

Add an instrument for openai to handle telemetry for chat completions

Is it applicable for Node or Browser or both?

Its applicable for Node

Do you expect this instrumentation to be commonly used?

Yes

Weekly Downloads:

What version of instrumentation are you interested in using?

Versions:

Code Owners

@AmanAgarwal041
@patcher9

Additional context

@AmanAgarwal041
Copy link
Author

@pichlermarc Does this instrumentation request good to get started ?

@pichlermarc
Copy link
Member

@AmanAgarwal041 thanks for opening the request

A few more questions:

  • did you reach out to the owners of the OpenAI org about hosting the package there?
  • is there a reason why you'd like to have this added here as opposed to hosting it in a seperate repo where you can have full control over issue triage, release cadence and more?

The reason I'm asking is that we're overwhelmed here with different instrumentation packages as we have to be familiar with the source code of the package we're instrumenting - we've had numerous component owners jump ship after contributing a component and it's simply not feasible for maintainers of this repo to be experts in the inner workings of 40+ wildly different packages.

As this is the case you'd still be mostly maintaining this yourself here, as you would in a separate repo - but with less permissions and less control over what you can do and cannot do.

@AmanAgarwal041
Copy link
Author

@pichlermarc to answer your questions

  • I haven't had a chance to reach out to openai org contributors about hosting it there. I feel like since the opentelemetry contrib packages for python are increasing and there is a still open issue for openai instrumentation, so it make sense to add a support for the js as well.
  • Creating it in a separate repo would actually be like following outdated semantic conventions. But keeping it here would actually restrict the maintainers to follow the otel conventions and keep it up to date.

I understand the maintaining it in a separate repo is lesser pain but keeping it here would actually make it trust worthy and genuine to get adopted.

@AmanAgarwal041
Copy link
Author

@pichlermarc I have created a draft PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants