We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, I want to verify if this is a bug or intended behavior of the current instrumentation code. I notice in the instrumentation code: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts#L236-L242
The span is ended right after it is created unless it's a middleware. It does not even measure the sync execution time of the actual handler.
Should it be put after this line to measure the original handle execution time? https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts#L285
I ran a few tests, the time measured for 'request handler' is extremely short, only a couple of microseconds.
Much appreciated for looking into this!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi, I want to verify if this is a bug or intended behavior of the current instrumentation code.
I notice in the instrumentation code: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts#L236-L242
The span is ended right after it is created unless it's a middleware. It does not even measure the sync execution time of the actual handler.
Should it be put after this line to measure the original handle execution time? https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts#L285
I ran a few tests, the time measured for 'request handler' is extremely short, only a couple of microseconds.
Much appreciated for looking into this!
The text was updated successfully, but these errors were encountered: