Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'd like to ...fix the data url for https://opentraits.org/datasets/elton-traits #213

Open
jhpoelen opened this issue Aug 9, 2022 · 9 comments
Assignees

Comments

@jhpoelen
Copy link
Member

jhpoelen commented Aug 9, 2022

Hi!

from https://opentraits.org/datasets/elton-traits - I found that the data url was broken suggest to update.

BErfanian added a commit that referenced this issue Sep 6, 2022
@BErfanian
Copy link
Contributor

Hi Jorrit
I've updated the file. Please check it.

@BErfanian BErfanian self-assigned this Sep 6, 2022
@jhpoelen
Copy link
Member Author

jhpoelen commented Sep 6, 2022

@BErfanian thanks for updating the contentURL and datasetDOI_URL

258ab8a

The datasetDOI_URL looks pretty good.

But, I am wondering about the contentURL . The idea is that the contentURL links directly to a data file. So, when you visit the URL, the data is downloaded right away. Now, if I follow the contentURL, a web page is displayed and no data is downloaded.

What do you think the contentURL should be populated with?

By the way - Thanks for all your editorial work to keep OTN up-to-date!

@BErfanian
Copy link
Contributor

The idea is that the contentURL links directly to a data file.

I think direct download is risky - data may contain malware or other unwanted files. Maybe DataDownloadURL will be a better option than contentURL.
:) Thank you. I did not receive the notifications, so I didn't notice the requests. I'll regularly check the GitHub page.

@jhpoelen
Copy link
Member Author

jhpoelen commented Sep 7, 2022

@BErfanian I can see your hesitation to add a direct download link. And, because we curate the link, we can make sure that the link doesn't link to some malware site. I try to check the content retrieved by the contentURL before adding it to the OTN registry.

In other words, I am ok with a direct download link, especially because then @bmaitner @caterinap and others can write automated scripts to create neat summaries like https://opentraits.org/otn-taxon-trait-summary/data_overview.html .

And, I am sure others have some ideas also.

@caterinap
Copy link
Member

Hi, yes direct links make automated scripts easier but it's also useful to get a link to the data description (paper or metadata). So having both (when possible) is a good idea.

@BErfanian
Copy link
Contributor

@jhpoelen
Copy link
Member Author

jhpoelen commented Sep 7, 2022

@BErfanian would it be an idea to list all of them, separated by | just like other lists? I imagine that scripts can be updated to handle lists as well as single values.

@BErfanian
Copy link
Contributor

@jhpoelen OK, I'll edit the file

@jhpoelen
Copy link
Member Author

jhpoelen commented Sep 9, 2022

@BErfanian thanks! Please let me know if you have any suggestions on how to better handle multiple direct contentURL links per datasets.

BErfanian added a commit that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants