Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return the same primitive as a recommendation if the security level is similar #41

Open
tshakalekholoane opened this issue Jun 21, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tshakalekholoane
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Return the input primitive as a recommendation if the recommended primitive would have the same or similar level of security.

Describe the solution you'd like

For example, currently the user might have a SHA3-256 and assessing its compliance, they might get recommended the SHA256. In most cases this would not be necessary and thus it might be better to return SHA3-256 instead, explicitly encoding that a switch need not be made.

Describe alternatives you've considered

Leave things as is. In most cases the default recommendation is a widely used primitive such as SHA256 that has been around longer and thus might have better hardware and library support than newer primitives (notwithstanding issues around its lack of resistance against length extension attacks in this particular case).

@tshakalekholoane tshakalekholoane added enhancement New feature or request good first issue Good for newcomers labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant