Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declaration maps and source maps are included in published packages but source code isn't #279

Open
DetachHead opened this issue Apr 27, 2022 · 0 comments · May be fixed by #280
Open

declaration maps and source maps are included in published packages but source code isn't #279

DetachHead opened this issue Apr 27, 2022 · 0 comments · May be fixed by #280
Labels
bug Something isn't working

Comments

@DetachHead
Copy link
Contributor

Are you using jest or chai?
n/a

Are you using OpenAPI 2, 3.0.X, or 3.1.0?
n/a

Describe the bug clearly
declarationMap and sourceMap are enabled in tsconfig.json

OpenAPIValidators/tsconfig.json

Lines 47 to 49 in 9511b66

"declarationMap": true /* Create sourcemaps for d.ts files. */,
// "emitDeclarationOnly": true, /* Only output d.ts files and not JavaScript files. */
"sourceMap": true /* Create source map files for emitted JavaScript files. */,

but the source code isn't included in the published packages, even though the .d.ts.map and .js.map files are

the source code should be included such that the declaration and source maps can be utilized by users for an improved development/debugging experience

Steps to reproduce the bug:

  1. npm install openapi-validator
  2. go to node_modules/openapi-validator
    image

What did you expect to happen instead?
src directory is present with the source code

Are you going to resolve the issue?
https://www.youtube.com/watch?v=kjRXis0L-Yg
@DetachHead DetachHead added the bug Something isn't working label Apr 27, 2022
@DetachHead DetachHead linked a pull request Apr 27, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include source code in published packages DetachHead/OpenAPIValidators
1 participant
@DetachHead