-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Movie Center EMC and MovieList: Filenames with special characters (dollar signs, quotation marks) #3492
Comments
EMC: MovieSelection: |
Thank you very much for looking into it, great work. I have tested MovieSelection on 7.4 with a filename with quotation marks and dollar sign in it and delete to trashcan or move didn't work. Of course I believe you and I will test it again. If you find the time to repair that problem in EMC it would be great. Otherwise please keep it on the todo list and maybe later there is some spare time. It is not a deal breaker for EMC. I just have to rename the file before moving it if I want to keep it. Direct delete works. But it would be nice if this would be solved some time. Thanks again! |
As i mentioned already in the oATV-Forum, there will be additional restrictions by handling of files with other operating systems like Windows, that is not able to handle files with a quotation mark in the filename. Shouldn't we stay in the more compatible state of handling filenames in E2? |
@Papi2000-new, you are absolutely right if you take Windows into account. First it is important to enable the tools and plugins to handle Linux filenames correctly, especially if they are integrated in OpenATV by default. Every software on Linux should handle filenames correctly. I tried to convince Taapat to create Windows compatible filenames but he responded that it looks bad and is not readable any more. Taapat agreed to change the downloaded file format from mkv to ts which is handled much better by the default player (jump, fast forward etc.). Now that the YouTube plugin creates ts files it would be possible to create a Windows compatible filename and put the original title into the meta data file (but I think this would have worked also for mkv). This solution would "look good" in EMC/Movie Selection and ensure Windows compatibility. But I have to ask Taapat to implement the solution. I think he would agree if it is not too complicated. I am not familiar in detail with creating meta data files in E2. I wrote a little Python script to modify the meta data for special recordings to my liking but I don't know how to create these files correctly. Is there an easy way in Python for E2 to implement a meta data file that contains the original title? |
Image: OpenATV 7.4
Box: VUDUO4K
After the download of YouTube videos using Taapat's plugin it is possible that the created files contain special characters. I worked and tested with Taapat to improve the handling of filenames with special characters in his plugin. It was a minor issue. Taapat just added single quotes around filenames when calling external commands (e. g. ffmpeg) and replaced possible single quotes.
Enhanced Movie Center and the MovieList (Filmauswahl) have problems with filenames containing quotation marks (" double quotes) and dollar signs ($). Deleting files to trashcan or moving files containing these characters in their filenames are not handled correctly. The Direct Delete of EMC (without trashcan) works.
The MovieList of OpenPLi Devel works perfectly fine with dollar signs and/or quotation marks in filenames. Taapat therefore asked me to request a correction of the image I used.
Thanks a lot for your great work.
The text was updated successfully, but these errors were encountered: