Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance position bounds to include coverage up to all-sky #102

Open
pdowler opened this issue Mar 28, 2019 · 4 comments
Open

enhance position bounds to include coverage up to all-sky #102

pdowler opened this issue Mar 28, 2019 · 4 comments

Comments

@pdowler
Copy link
Member

pdowler commented Mar 28, 2019

The current Polygon definition is limited to less than all-sky. A MultiPolygon with two hemispheres could be constructed, but you cannot create an outer simple polygon that contains it.

@pdowler
Copy link
Member Author

pdowler commented Apr 11, 2019

Whatever we do has to:

  • be exposed from TAP via DALI polygon or multipolygon or STC serialisation
  • be implementable in database so TAP queries return correctly (already issues lurking here)

@pdowler
Copy link
Member Author

pdowler commented Apr 12, 2019

A caom2 MultiPolygon that describes two opposite hemispheres already means all-sky, but the simple DALI polygon in Plane.position.bounds cannot. There is work within the IVOA to augment DALI with support for multipolygon and shape (polymorphism) and this may impact how the CAOM Polygon and MultiPolygon will work

@pdowler
Copy link
Member Author

pdowler commented Apr 12, 2019

tentatively added to UML using what was discussed for DALI

@pdowler pdowler added develop and removed develop labels Apr 12, 2019
@pdowler
Copy link
Member Author

pdowler commented Nov 28, 2019

The DALI polygon will not be extended to have a special value for all sky. There will be a polymorphic DALI "shape" that allows polygon or circle values (and this matches the type of Plane.position.bounds).

In CAOM, all sky can be specified (in Plane.position.bounds) as a Circle with radius 180 (degrees). Anything less than that can be specified as a DALI polygon.

note: Limitations in back end implementations will cause these to fail (at least at CADC) until we can implement code to handle these cases and remove limits on maximum polygon size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant