Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos does not stop playing when closing modal #238

Open
dagraf opened this issue Jan 8, 2024 · 0 comments
Open

Videos does not stop playing when closing modal #238

dagraf opened this issue Jan 8, 2024 · 0 comments
Labels
bug Something isn't working Priority: Low Needs to be fixed/taken care when there is some spare time

Comments

@dagraf
Copy link

dagraf commented Jan 8, 2024

Describe the bug
Bug only exists, when in the config of the plugin the option "Open player in modal" is activated (see tab "Settings", subtab "Events"). When a user opens a video by clicking on the button "Play" and then on the play icon, the modal gets opened and then the video starts. When the user then closes the modal, the modal gets closed but the videos keeps running leading and the audio is still aadible via the speakers

To Reproduce
Steps to reproduce the behavior:

  1. In the config of the plugin: Activate the option "Open player in modal" (see tab "Settings", subtab "Events")
  2. Click on 'Play' on any video and then on the play icon in the opened modal
  3. Close the modal by clicking on the 'x' in the top right corner
  4. See error: Video does not stop.

Expected behavior
When the modal of a running video gets closed the video should stop.

Environment (please complete the following information):

  • ILIAS version: v7.26 2023-10-23
  • Plugin version: 5.6.0
  • Opencast version: 14
  • Browser: Firefox

Additional context
Bug also exits in PR #237.

@dagraf dagraf added bug Something isn't working Priority: Low Needs to be fixed/taken care when there is some spare time labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: Low Needs to be fixed/taken care when there is some spare time
Projects
Status: Backlog
Development

No branches or pull requests

1 participant