Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour for process context management? #23

Closed
garthk opened this issue Jul 24, 2019 · 2 comments
Closed

Behaviour for process context management? #23

garthk opened this issue Jul 24, 2019 · 2 comments

Comments

@garthk
Copy link

garthk commented Jul 24, 2019

Further to the discussion about :seq_trace we ended up having in absinthe-graphql/absinthe#757, and it being polite to come up with a way to not stuff up people already using the label, it occurs to me we could:

  • define a @behaviour for remembering a span context for the current process, retrieving it later, and retrieving it from our parents
  • provide one implementation satisfying it with the process dictionary
  • provide another satisfying it :seq_trace
  • let people configure which one they wanted to use

… and then if someone needed the seq_trace using the seq_trace label already, they could whip up their own implementation to coordinate things.

Such a behaviour should properly be configured and used from :opencensus, but I'll prototype it in Elixir in our app's fork of with_child_span/3 and report back on how it goes.

@tsloughter
Copy link
Member

This is what I'm doing with a proposal implementation for OpenTelemetry Erlang lib. I hope to have a PR open in the next day or so for comment.

@garthk
Copy link
Author

garthk commented Dec 4, 2019

Moot, given the OT work.

@garthk garthk closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants