Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for metrics #27

Closed
wants to merge 8 commits into from
Closed

Add support for metrics #27

wants to merge 8 commits into from

Conversation

mszczygiel
Copy link

fixes #24

hauleth
hauleth reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@hauleth hauleth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is nice, we currently focusing on getting on track with OpenTelemetry and few thing can change till then.

lib/opencensus/metrics.ex Outdated Show resolved Hide resolved
lib/opencensus/metrics.ex Outdated Show resolved Hide resolved
lib/opencensus/metrics.ex Outdated Show resolved Hide resolved
config/config.exs
stat: [
export_interval: 100,
exporters: [
{Opencensus.TestSupport.MetricsCaptureExporter, []}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would dynamically attach exporter in tests as it will allow to make test async.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't think attaching it dynamically makes any difference. I think it's fine to just make tests async (which I just did)

@codecov-io
Copy link

codecov-io commented Oct 24, 2019 •
edited
Loading

Codecov Report

Merging #27 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #27     +/-   ##
=========================================
+ Coverage   98.24%   98.64%   +0.4%     
=========================================
  Files           5        7      +2     
  Lines          57       74     +17     
=========================================
+ Hits           56       73     +17     
  Misses          1        1
Impacted Files Coverage Δ
lib/opencensus/metrics.ex 100% <100%> (ø)
...pencensus/test_support/metrics_capture_exporter.ex 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f968f96...e909dab. Read the comment docs.

@mszczygiel mszczygiel closed this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauleth hauleth hauleth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for measurements
3 participants
@mszczygiel @codecov-io @hauleth