Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement runtime warnings for functional property setters #17

Open
iosonopersia opened this issue Jan 28, 2022 · 0 comments
Open

Implement runtime warnings for functional property setters #17

iosonopersia opened this issue Jan 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@iosonopersia
Copy link
Collaborator

iosonopersia commented Jan 28, 2022

Setter methods that correspond to a functional property (e.g. hasTitle for a BibliographicResource) should either

  • generate a runtime warning when an already existing value gets overwritten
  • or allow the user to set a parameter flag to tell them not to update the value if another one is already set.

A similar functionality should be discussed and implemented also for "remover" methods that correspond to non-functional properties (e.g. remove_format for BibliographicResource): when the user doesn't specify a specific value to remove, the current implementation deletes all existing values. Instead, it should inform at runtime the user that he/she may have inadvertently forgot to specify the value to be deleted.

@iosonopersia iosonopersia added the enhancement New feature or request label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant