Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teardown Tests Should Accept 404 Response for Blob Deletion #540

Closed
gorkem opened this issue Jun 17, 2024 · 2 comments · Fixed by #541
Closed

Teardown Tests Should Accept 404 Response for Blob Deletion #540

gorkem opened this issue Jun 17, 2024 · 2 comments · Fixed by #541

Comments

@gorkem
Copy link

gorkem commented Jun 17, 2024

The current teardown tests use the blob delete operation to clean up blobs uploaded during the setup phase. A 404 response is a valid outcome for blob deletion; however, the teardown tests do not currently accept a 404 response.

When running the conformance tests with the OCI_DELETE_MANIFEST_BEFORE_BLOBS=1 environment variable, it is possible for the garbage collection implementation to delete blobs immediately after the manifest is deleted. In such cases, the blobs may no longer exist when the teardown process attempts to delete them, resulting in a 404 response.

To accommodate this scenario, the teardown tests should be updated to expect a 404 response if the manifests are deleted before the blobs.

@sudo-bmitch
Copy link
Contributor

Thanks. That's easy enough to permit. Let us know if #541 resolves it for your registry.

@gorkem
Copy link
Author

gorkem commented Jun 17, 2024

Thanks for the swift PR. Works perfectly. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants