Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components / Tab #3762

Open
jpye-finch opened this issue Aug 11, 2022 · 0 comments
Open

Components / Tab #3762

jpye-finch opened this issue Aug 11, 2022 · 0 comments
Labels
UI/UX

Comments

@jpye-finch
Copy link
Collaborator

jpye-finch commented Aug 11, 2022 •
edited by naftis
Loading

We currently have two Tab components FormTabs and Tabs.

This ticket is to review and look to refactor:

  • Might be as simple as renaming FormTabs to Tabs
  • Two components in the code Tabs and Tab?
  • or one component called Tabs

Code

Components/Tabs

  • Tab.tsx
  • Tabs.tsx
  • Tabs.stories.tsx

Accessibility

https://www.w3.org/WAI/ARIA/apg/example-index/tabs/tabs-automatic
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role

  • Make sure that the tabs can be navigated to with keyboard
  • Make sure that they have proper focus state, and it's clear which tab is currently selected
  • Make sure aria -props are properly set up (see links above)

Storybook

/ Controls / Tab

  • example with multiple Tabs
  • Tab 1, Tab 2, Tab3
  • hover, focus, active and disabled state
@jpye-finch jpye-finch changed the title Assess and refactor Tabs Component: Tab Aug 11, 2022
@jpye-finch jpye-finch changed the title Component: Tab Component / Tab Aug 11, 2022
@jpye-finch jpye-finch changed the title Component / Tab Components / Tab Aug 11, 2022
@naftis naftis removed their assignment Jun 6, 2023
@jpye-finch jpye-finch moved this to Backlog in OpenCRVS Core Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI/UX
Projects
OpenCRVS Core
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naftis @jpye-finch