Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeRay v1.0.0 release is out, need to update from 0.6.0 to 1.0.0 #158

Open
jbusche opened this issue Nov 14, 2023 · 2 comments
Open

KubeRay v1.0.0 release is out, need to update from 0.6.0 to 1.0.0 #158

jbusche opened this issue Nov 14, 2023 · 2 comments

Comments

@jbusche
Copy link
Contributor

jbusche commented Nov 14, 2023

https://github.com/ray-project/kuberay/releases/tag/v1.0.0 is out! Time to try updating from 0.6.0 to 1.0.0. The rc.0 candidate PR looked good, so this should be a pretty straight forward, and then need to test it.

I volunteer to do this...

@jbusche
Copy link
Contributor Author

jbusche commented Nov 15, 2023

OK - created PR #159
But that's been put on hold, needs to go instead into https://github.com/opendatahub-io/kuberay instead.

@jbusche
Copy link
Contributor Author

jbusche commented Nov 15, 2023

Anish posted in Slack: https://project-codeflare.slack.com/archives/C04L7QH4Q84/p1700051861762339?thread_ts=1700042717.704249&cid=C04L7QH4Q84

I see you raised #159, but I think this isn't actually the right upgrade path any more... Updating https://github.com/opendatahub-io/kuberay is.
In the short term, we need to:

  1. Create a release-1.0.0 branch in odh/kuberay. This branch should be a mirror of the upstream release branch: https://github.com/ray-project/kuberay/tree/release-1.0
  2. We should cherry-pick all odh specific commits from odh/master into this release branch. We would also want to include the FIPS related changes that were merged in as part of Make KubeRay Operator Image FIPS compliant ray-project/kuberay#1633
  3. We would build a new image from this release branch and push it up to the ODH Quay org.
  4. I'm a little hazy after this point.... How do we update the CodeFlare Operator? Do we first update https://github.com/project-codeflare/codeflare-operator and then pull it into odh/codeflare?
  5. We should document this process.
  6. We will need to talk further about how to get it into RHDS downstream, but that's a concern for a little later.

Longer term.... we need to figure out the update strategy/how to fix the commits. Just some random thoughts

  1. Make a copy of odh/kuberay master, just to be safe. Perhaps we call it odh-backup or something.
  2. Nuke existing master branch
  3. Sync correctly
  4. Create new branch from master, call it odh-dev or similar for now
  5. cherry-pick (or via PR?) our odh specific changes from odh-backup into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant