WIP: Populate Elyra runtime images configMap from runtime images imagestream manifests and mounts it on the Notebook CR

[atheo89]

Related to: https://issues.redhat.com/browse/RHOAIENG-19051

Related PRs for this workload:
New set of runtime ImageStreams: opendatahub-io/notebooks#888
Unwire .json files from the Datascience Notebook: opendatahub-io/notebooks#909

Description

This PR add a new notebook_runtime script where includes the logic to create/watch/update a new ConfigMap the pipeline-runtime-images from the runtime images imagesStreams (related PR) and mount it as volume with the name /opt/app-root/pipeline-runtimes/ on the notebook CR when is getting created.

Moreover, on this PR has been added the SET_RUNTIMES_CM DevFlag to enable/disable this feature.

TODO items:

• Update/Write tests to cover the new changes
• Update the GHA to update the runtimes SHAs to the new place
• Remove from this PR Makefile and on the param.env changes

How Has This Been Tested?

NOTE: Please don't pay attention on the Makefile and on the param.env changes. I will revert them, they are there for testing purposes

1. Update the RHOAI DSC with the following:

    workbenches:
      devFlags:
        manifests:
          - contextDir: components/odh-notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/atheo89/kubeflow/archive/rhoaieng-19050-configmap-generator.tar.gz'
          - contextDir: manifests
            sourcePath: ''
            uri: 'https://github.com/atheo89/notebooks/archive/rhoaieng-19050.tar.gz'
      managementState: Managed
      

2. Import the quay.io/rh_ee_atheodor/workbench-images@sha256:f2bc105afab97575007a5743e39cc4c045fa276ba8612b6a8241758d48711913 notebook (Includes the changes from this PR) This is a notebook without the .json runtimes in it.

3. Spin up this Custom Datascience notebook via UI
   Click on the left side menu and click this icon.
   

You should see the runtimes mounted like below:

On the Back-end side:
4. Inspect the logs on the odh-notebook-controller to find the related logs on the configMap creation and the mounting, like below.

...
{"level":"info","ts":"2025-02-20T10:13:31Z","logger":"controllers.Notebook","msg":"Created new ConfigMap for runtime images","namespace":"atheo","ConfigMap.Name":"pipeline-runtime-images"}
...
{"level":"info","ts":"2025-02-20T10:13:31Z","logger":"controllers.Notebook","msg":"Injecting runtime-images volume into notebook","notebook":"t1","namespace":"atheo","notebook":"t1","namespace":"atheo"}
...

5. Check on the notebook pod statefullset for the config map, press on it to inspect also the data from this configMap
   

6. Check as well on the notebook CR to evaluate the mounting, as is on the bellow image:
   

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atheo89]

/hold
Until investigate if we have any issue with notebook tile

[jiridanek]

Suggested change

	// Create a dynamic client
	config, err := rest.InClusterConfig()
	if err != nil {
	log.Error(err, "Error creating cluster config")
	return err
	}
	dynamicClient, err := dynamic.NewForConfig(config)
	if err != nil {
	log.Error(err, "Error creating dynamic client")
	return err
	}
	// Create a dynamic client
	dynamicClient, err := dynamic.NewForConfig(r.Config)
	if err != nil {
	log.Error(err, "Error creating dynamic client")
	return err
	}

[jiridanek]

set this in main.go?

Config:    mgr.GetConfig(),

and also in suite_test.go for tests?

[jiridanek]

just a note that code in this file is not run in envtest, according to codecov

[atheo89]

Thank you Jiri for your review! I will try to fix that, maybe i will reach you out to at some point to consult me with this new test framework.

[openshift-ci]

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/odh-notebook-controller-unit	999d76a	link	true	/test odh-notebook-controller-unit
ci/prow/odh-notebook-controller-e2e	999d76a	link	true	/test odh-notebook-controller-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[atheo89]

FYI folks I will close this PR and i will work for the tests in my fork branch in order to don't spam you all the time with notifications. 🤣