RHOAIENG-18401, RHOAIENG-18402: chore(.tekton/, .github/renovate.json): configure Konflux build and Renovate #514
Conversation
…managers we are not ready to have around yet
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jiridanek
changed the title
…DH-io/kubeflow repository
|
|
||
| """ | ||
| This script is used to configure a Konflux Application with component definitions. | ||
| We have very many components, and clicking them one by one in the UI is too inefficient. |
There was a problem hiding this comment.
when you say we have many components - you mean what? nbc controller, kf nbc controller and?
There was a problem hiding this comment.
each has two pipelines, so it's one, two, three, many when counting pipelines
|
How often do we need to regenerate the tekton pipelines? Is it really worth it to have a special generator code for them? 🤔 Anyway, since it's already scripted, I'm not against it. I'm just not sure whether we'll be utilizing it that often. Maybe I'm wrong as I may be missing the use case here. |
It's necessary for opendatahub-io/notebooks, because there it's two pipelines per each image. And I just reused same script here. One use case will be migrating the pipeline to multiarch build; Imo that will be nicer to do by updating the python than editing yamls directly. You're right that this is not going to be used often, most likely. |
|
Okay, I didn't take into account the notebooks repository. I'm just fine with it if it works as expected. I have zero knowledge about this TBH. Will give lgtm, but wait for some other person to do so too, please. /lgtm |
| workspace_name = "rhoai-ide-konflux-tenant" | ||
| application_name = "kubeflow" | ||
| git_revision = "main" | ||
| git_url = "https://github.com/opendatahub-io/notebooks" |
There was a problem hiding this comment.
Should this be pointing to this repo ?
| kind: PipelineRun | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} |
There was a problem hiding this comment.
should this be pointing to this repo ?
the configuration seems to have been all on this repo, is there some reason for this to point to notebooks repo?
| { | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "description": [ | ||
| "https://raw.githubusercontent.com/red-hat-data-services/kubeflow/refs/heads/main/.github/renovate.json", |
There was a problem hiding this comment.
is this file auto generated ?
can you share why it has the red-hat-data-services url?
Description
Based on the defaults at https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json
We need to stop MintMaker/Renovate from trying to update all our Pipfiles.
Configure Konflux build for the notebook-controller components
How Has This Been Tested?
https://docs.renovatebot.com/config-validation/