ISSUE #883: chore: add data-testid attribute for loading spinner (#910

) * feat: add data-testid attribute for loading spinner * feat: change assert for data-testid attribute * fix: incomplete attribute * chore: keep long lines
opendatahub-io · Feb 20, 2025 · 77edf72 · 77edf72
1 parent 668dfae
commit 77edf72
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/2024b/jupyter/utils/addons/partial-body.html b/2024b/jupyter/utils/addons/partial-body.html
@@ -5,7 +5,14 @@
     viewBox="0 0 100 100"
     aria-label="Loading..."
   >
-    <circle class="pf-v6-c-spinner__path" cx="50" cy="50" r="45" fill="none" />
+    <circle
+      class="pf-v6-c-spinner__path"
+      data-testid="loading-spinner-initial"
+      cx="50"
+      cy="50"
+      r="45"
+      fill="none"
+    />
   </svg>
 </div>
 

diff --git a/tests/containers/workbenches/jupyterlab/jupyterlab_test.py b/tests/containers/workbenches/jupyterlab/jupyterlab_test.py
@@ -49,7 +49,7 @@ def test_spinner_html_loaded(self, image: str) -> None:
             response = requests.get(f"http://{host_ip}:{host_port}/notebook/opendatahub/jovyan")
             assert response.status_code == 200
             assert "text/html" in response.headers["content-type"]
-            assert 'class="pf-v6-c-spinner"' in response.text
+            assert 'data-testid="loading-spinner-initial"' in response.text
         finally:
             docker_utils.NotebookContainer(container).stop(timeout=0)