Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pity we didn't put some testid attribute to this our extra element against which we could check here... #883

Open
jiridanek opened this issue Feb 4, 2025 · 1 comment · Fixed by #910
Open

pity we didn't put some testid attribute to this our extra element against which we could check here... #883

jiridanek opened this issue Feb 4, 2025 · 1 comment · Fixed by #910
Labels
good first issue Good for newcomers

Comments

@jiridanek
Copy link
Member 

          pity we didn't put some `testid` attribute to this our extra element against which we could check here...

Originally posted by @jstourac in #874 (comment)
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Feb 4, 2025
@jiridanek jiridanek mentioned this issue Feb 4, 2025
Merged
3 tasks
@jiridanek jiridanek added the good first issue Good for newcomers label Feb 4, 2025
@jstetina jstetina mentioned this issue Feb 20, 2025
Merged
3 tasks
@jiridanek jiridanek linked a pull request Feb 20, 2025 that will close this issue
ISSUE #883: feat: add data-testid attribute for loading spinner #910
Merged
3 tasks
jiridanek pushed a commit that referenced this issue Feb 20, 2025
@jstetina
ISSUE #883: chore: add data-testid attribute for loading spinner (#910
77edf72 
)

* feat: add data-testid attribute for loading spinner

* feat: change assert for data-testid attribute

* fix: incomplete attribute

* chore: keep long lines
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅Done in ODH IDE Planning Feb 20, 2025
@jiridanek
Copy link
Member Author

we'll need to get this to main branch, after this is merged

@jiridanek jiridanek reopened this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
ODH IDE Planning
Status: ✅Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE #883: feat: add data-testid attribute for loading spinner jstetina/odh-notebooks
1 participant
@jiridanek