Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root:socket_proxy.py:88 Proxying failed to listen #922

Open
jiridanek opened this issue Feb 25, 2025 · 3 comments
Open

root:socket_proxy.py:88 Proxying failed to listen #922

jiridanek opened this issue Feb 25, 2025 · 3 comments
Labels
kind/bug Something isn't working

Comments

@jiridanek
Copy link
Member

https://github.com/opendatahub-io/notebooks/actions/runs/13524125351/job/37791017649#step:40:181

INFO     root:socket_proxy.py:76 Proxy listening on localhost:0
INFO     root:socket_proxy.py:85 Accepted connection from 127.0.0.1:48394
ERROR    root:socket_proxy.py:88 Proxying failed to listen
Traceback (most recent call last):
  File "/home/runner/work/notebooks/notebooks/tests/containers/socket_proxy.py", line 86, in listen_and_serve_until_canceled
    self._handle_client(client_socket)
  File "/home/runner/work/notebooks/notebooks/tests/containers/socket_proxy.py", line 113, in _handle_client
    data = remote_socket.recv(self.buffer_size)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 104] Connection reset by peer
=============================== warnings summary ===============================
tests/containers/workbenches/workbench_image_test.py::TestWorkbenchImage::test_image_run_on_openshift[ghcr.io/opendatahub-io/notebooks/workbench-images:jupyter-trustyai-ubi9-python-3.11-main_d954ab6f6b7e476ee38dd8ed6cd22f24aa726fd7]
  /home/runner/.cache/pypoetry/virtualenvs/notebooks-OIIyMdoB-py3.12/lib/python3.12/site-packages/kubernetes/client/exceptions.py:91: DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.
    self.headers = http_resp.getheaders()

tests/containers/workbenches/workbench_image_test.py::TestWorkbenchImage::test_image_run_on_openshift[ghcr.io/opendatahub-io/notebooks/workbench-images:jupyter-trustyai-ubi9-python-3.11-main_d954ab6f6b7e476ee38dd8ed6cd22f24aa726fd7]
  /home/runner/.cache/pypoetry/virtualenvs/notebooks-OIIyMdoB-py3.12/lib/python3.12/site-packages/_pytest/threadexception.py:82: PytestUnhandledThreadExceptionWarning: Exception in thread Thread-1 (listen_and_serve_until_canceled)
  
  Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.12.9/x64/lib/python3.12/threading.py", line 1075, in _bootstrap_inner
      self.run()
    File "/opt/hostedtoolcache/Python/3.12.9/x64/lib/python3.12/threading.py", line 1012, in run
      self._target(*self._args, **self._kwargs)
    File "/home/runner/work/notebooks/notebooks/tests/containers/socket_proxy.py", line 86, in listen_and_serve_until_canceled
      self._handle_client(client_socket)
    File "/home/runner/work/notebooks/notebooks/tests/containers/socket_proxy.py", line 113, in _handle_client
      data = remote_socket.recv(self.buffer_size)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ConnectionResetError: [Errno 104] Connection reset by peer
  
    warnings.warn(pytest.PytestUnhandledThreadExceptionWarning(msg))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
@jiridanek jiridanek added the kind/bug Something isn't working label Feb 25, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Feb 25, 2025
@jiridanek
Copy link
Member Author

looks like there's some retry logic needed in the test

@jiridanek
Copy link
Member Author

Given that the logs also say

INFO     root:kubernetes_utils.py:295 Pods matching test-ns-notebook-tests-pod/app=notebook-tests-pod are ready

could be this is actually manifestation of https://issues.redhat.com/browse/RHOAIENG-1576

@jiridanek
Copy link
Member Author

On the gripping hand though, we don't have proper readiness checks in this test set up in the pod, so likely this is irrelevant for the Jira I just mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant