Add more test cases for R Studio notebook

[atheo89]

Description

This is an enhancement on the test framework for RStudio notebook.

The new tests include:

• Create, save, and execute R script.
• Evaluate if can be download R package

How Has This Been Tested?

1. Copy your login cmd from your ocp cluster to your terminal
2. Run make rstudio-c9s-python-3.9 -e IMAGE_REGISTRY=quay.io/${YOUR_QUAY_USER}/workbench-images
3. Run make deploy-c9s-rstudio-c9s-python-3.9
4. Give a bit of time till the pod be in running status and run make validate-rstudio-image image=rstudio-c9s-python-3.9-2023b_20230129 (check to be the correct tag)
5. Once you evaluate/enhance the testing run make undeploy-c9s-rstudio-c9s-python-3.9 to destroy the testing pod

Bellow are are the logs from the make validate-rstudio-image image=rstudio-c9s-python-3.9-2023b_20230129 execution:

# Running tests for  RStudio image...
bin/kubectl wait --for=condition=ready pod rstudio-pod --timeout=300s
pod/rstudio-pod condition met
=> Checking container image rstudio-c9s-python-3.9-2023b_20230129 for package intallation...
Tinytex installation successful!
=> Checking container image rstudio-c9s-python-3.9-2023b_20230129 for curl...
curl executed successfuly!
=> Checking container image rstudio-c9s-python-3.9-2023b_20230129 for python...
python executed successfuly!
=> Checking container image rstudio-c9s-python-3.9-2023b_20230129 for oc...
oc executed successfuly!
=> Checking container image rstudio-c9s-python-3.9-2023b_20230129 for /usr/lib/rstudio-server/bin/rserver...
/usr/lib/rstudio-server/bin/rserver executed successfuly!
=> Creating R file and executing on the container...
R script executed successfully!

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[jiridanek]

General workflow suggestion: What's the point of having a How Has This Been Tested? docs on test PRs?

Since we care whether the tests run in CI or not, I think the most practical way to test tests is to create a PR, wait for CI to run the added tests, and then add a link to the test report from the CI.

The instructions on how to run tests locally on your own machine should be in a .md file in the repository, not repeated every time on every PR.

[atheo89]

General workflow suggestion: What's the point of having a How Has This Been Tested? docs on test PRs?

Since we care whether the tests run in CI or not, I think the most practical way to test tests is to create a PR, wait for CI to run the added tests, and then add a link to the test report from the CI.

The instructions on how to run tests locally on your own machine should be in a .md file in the repository, not repeated every time on every PR.

We need enhancements for sure! However, this section serves as a mandatory requirement for the developer to document the testing process steps. It is crucial to provide clear instructions to the reviewer, ensuring they can easily catch up and replicate the pull request on their end.

[jiridanek]

We need enhancements for sure! However, this section serves as a mandatory requirement for the developer to document the testing process steps.

Sure, but since what you are adding here are automated test scripts, it seems unproductive to me to repeatedly document the steps needed for their execution in every PR raised. This should be done once, in a https://github.com/opendatahub-io/notebooks/blob/main/docs/developer-guide.md or a separate document linked to it, and then it can be referenced as needed.

Besides, what is important is not checking that the tests run as expected on people's laptops, but that the tests run on the CI. Reviewers should not need to manually repeat automated tests that the CI is already running. (CI is running this, I hope).

[harshad16]

Great work,
one small comment

[openshift-ci]

@jiridanek: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harshad16]

/lgtm
/approve

thanks 💯

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harshad16]

/cherrypick 2023b

[openshift-cherrypick-robot]

@harshad16: new pull request created: #424

In response to this:

/cherrypick 2023b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.