-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate settings.json file on vscode server workbench #415
Incorporate settings.json file on vscode server workbench #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor proposals
otherwise LGTM
c480a16
to
5a8fa43
Compare
5a8fa43
to
2d98928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, LGTM
Please rebase the PR. |
2d98928
to
8d23be4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick 2023b |
@harshad16: #415 failed to apply on top of branch "2023b":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…st-updater-11407912690 [Digest Updater Action] Update Runtime Images
Related to: https://issues.redhat.com/browse/RHOAIENG-2312
Description
This PR enables passing the settings.json file located within local/share/code-server/User/ in vscode. This is done to utilize the defaultInterpreterPath setting, thereby facilitating the selection of the interpreter.
On the official documentation is mentioned the following:
Note: Changes to this setting made after an interpreter has been selected for a workspace will not be applied or considered by the Python extension. The Python extension doesn't automatically add or change this setting.
Therefore, in accordance with that, and since we have already pre-installed the Python extension, the user should specify the "/opt/app-root/bin/python3" interpreter at least once.
Merge criteria: