Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate settings.json file on vscode server workbench #415

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Feb 13, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-2312

Description

This PR enables passing the settings.json file located within local/share/code-server/User/ in vscode. This is done to utilize the defaultInterpreterPath setting, thereby facilitating the selection of the interpreter.

On the official documentation is mentioned the following:

Note: Changes to this setting made after an interpreter has been selected for a workspace will not be applied or considered by the Python extension. The Python extension doesn't automatically add or change this setting.

Therefore, in accordance with that, and since we have already pre-installed the Python extension, the user should specify the "/opt/app-root/bin/python3" interpreter at least once.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor proposals

otherwise LGTM

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, LGTM

@harshad16
Copy link
Member

Please rebase the PR.
will be tested.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 💯

Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit da0dfa3 into opendatahub-io:main Feb 22, 2024
5 checks passed
@harshad16
Copy link
Member

/cherrypick 2023b

@openshift-cherrypick-robot

@harshad16: #415 failed to apply on top of branch "2023b":

Applying: Pass settings.json file on vscode server workbench
Using index info to reconstruct a base tree...
M	codeserver/ubi9-python-3.9/run-code-server.sh
Falling back to patching base and 3-way merge...
Auto-merging codeserver/ubi9-python-3.9/run-code-server.sh
CONFLICT (content): Merge conflict in codeserver/ubi9-python-3.9/run-code-server.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Pass settings.json file on vscode server workbench
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick 2023b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atheo89 atheo89 deleted the vs-interpreter branch October 23, 2024 08:02
atheo89 pushed a commit to atheo89/notebooks that referenced this pull request Nov 8, 2024
…st-updater-11407912690

[Digest Updater Action] Update Runtime Images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants