-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RStudio Server Notebook #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. R.version returns 4.3.3
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work
thanks 💯
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, rkpattnaik780 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
i do not think this is working, |
CI validation of the params.env file for this PR failed but it got still merged 🙃 https://github.com/opendatahub-io/notebooks/actions/runs/8278818862/job/22651961748 - can I improve it anyhow so we can avoid this in the future? 🙂 |
We will address the fix in a separate PR, shortly. |
Relate to: https://issues.redhat.com/browse/RHOAIENG-4374
Description
This pull request updates the following components:
rstudio-server-rhel-2023.06.1-524
torstudio-server-rhel-2023.12.1-402
4.3.1
to4.3.3
NOTE: I moved down the N-1 to N-2, the N to N-1 and the updated one to N. Shall we keep the N-2 or we can drop it?
How Has This Been Tested?
Way 1
podman run --network=host --name validation-container quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-453
Way 2
Merge criteria: