Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RStudio Server Notebook #453

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 12, 2024

Relate to: https://issues.redhat.com/browse/RHOAIENG-4374

Description

This pull request updates the following components:

  • The RStudio Server version from rstudio-server-rhel-2023.06.1-524 to rstudio-server-rhel-2023.12.1-402
  • Update R from 4.3.1 to 4.3.3
  • Update the RStudio related ImageStreams and kustomization artifacts
    NOTE: I moved down the N-1 to N-2, the N to N-1 and the updated one to N. Shall we keep the N-2 or we can drop it?

How Has This Been Tested?

Way 1

  • Run podman run --network=host --name validation-container quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-453
  • Inspect the notebook

Way 2

  • Import the notebook in ODH
    image
  • Lunch the newly added notebook , you should see the following
    image

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 changed the title Update RStudio Notebook Update RStudio Server Notebook Mar 12, 2024
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. R.version returns 4.3.3

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 49b285a link true /test images
ci/prow/notebooks-e2e-tests 49b285a link true /test notebooks-e2e-tests
ci/prow/runtime-intel-pyt-ubi9-python-3-9-pr-image-mirror 49b285a link true /test runtime-intel-pyt-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror 49b285a link true /test notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror 49b285a link true /test notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror 49b285a link true /test runtime-intel-tf-ubi9-python-3-9-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work
thanks 💯

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 14, 2024
@harshad16 harshad16 merged commit ac54cf2 into opendatahub-io:main Mar 14, 2024
3 of 11 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, rkpattnaik780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member

zdtsw commented Mar 15, 2024

i do not think this is working, odh-rstudio-gpu-notebook-n-2 is not set in the params.env and rstudio-gpu-notebook-imagestream.yaml

@jstourac
Copy link
Member

CI validation of the params.env file for this PR failed but it got still merged 🙃 https://github.com/opendatahub-io/notebooks/actions/runs/8278818862/job/22651961748 - can I improve it anyhow so we can avoid this in the future? 🙂

@harshad16
Copy link
Member

We will address the fix in a separate PR, shortly.

@atheo89 atheo89 deleted the RHOAIENG-4374 branch October 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants