Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ImageStream objects for the runtime images #888

Open
wants to merge 1 commit into
base: refactor/konflux-migration
Choose a base branch
from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Feb 5, 2025

Related to: https://issues.redhat.com/browse/RHOAIENG-19050 [part 1/x]

Description

This PR introduces six newly created ImageStreams to utilize runtime images via manifests.

The .json with its metadata incorporated under the imagestream using the opendatahub.io/runtime-image-metadata annotation.

‼️ NOTE: Please review the annotation fields carefully 🙂 and provide feedback on whether they meet our requirements. I will update later on with thir inclusion on N and N-1 directories

How Has This Been Tested?

Used DevFlags on the RHOAI DSC

    workbenches:
      devFlags:
        manifests:
          - contextDir: manifests
            sourcePath: ''
            uri: 'https://github.com/atheo89/notebooks/archive/rhoaieng-19050.tar.gz'
      managementState: Managed

image

This is what the runtime ImageStream looks like when generated by the RHOAI operator:

kind: ImageStream
apiVersion: image.openshift.io/v1
metadata:
  annotations:
    platform.opendatahub.io/instance.name: default-workbenches
    internal.config.kubernetes.io/previousNamespaces: default
    opendatahub.io/runtime-image-url: 'https://github.com//opendatahub-io/notebooks/tree/main/runtimes'
    internal.config.kubernetes.io/previousKinds: ImageStream
    opendatahub.io/runtime-image-name: Datascience with Python 3.11 (UBI9)
    platform.opendatahub.io/instance.generation: '1'
    opendatahub.io/runtime-image-desc: 'Datascience runtime image for Elyra, enabling pipeline execution from Workbenches with a set of advanced AI/ML data science libraries, supporting different runtimes for various pipeline nodes.'
    internal.config.kubernetes.io/previousNames: runtime-datascience
    platform.opendatahub.io/version: 2.18.0
    openshift.io/image.dockerRepositoryCheck: '2025-02-05T10:33:49Z'
    platform.opendatahub.io/instance.uid: d373a9b1-54b5-4bb3-8f78-86b435e2288b
    platform.opendatahub.io/type: OpenShift AI Self-Managed
  resourceVersion: '66395157'
  name: runtime-datascience
  uid: 6c973fd7-e08f-4b9c-9de9-0ccfe53709c8
  creationTimestamp: '2025-02-05T10:33:38Z'
  generation: 2
  namespace: redhat-ods-applications
  labels:
    app.kubernetes.io/part-of: workbenches
    app.opendatahub.io/workbenches: 'true'
    component.opendatahub.io/name: notebooks
    opendatahub.io/component: 'true'
    opendatahub.io/runtime-image: 'true'
    platform.opendatahub.io/part-of: workbenches
spec:
  lookupPolicy:
    local: true
  tags:
    - name: datascience
      annotations:
        opendatahub.io/runtime-image-metadata: |
          [
            {
              "display_name": "Datascience with Python 3.11 (UBI9)",
              "metadata": {
                "tags": [
                  "datascience"
                ],
                "display_name": "Datascience with Python 3.11 (UBI9)",
                "image_name": "quay.io/opendatahub/workbench-images@sha256:304d3b2ea846832f27312ef6776064a1bf3797c645b6fea0b292a7ef6416458e",
                "pull_policy": "IfNotPresent"
              },
              "schema_name": "runtime-image"
            }
          ]
        openshift.io/imported-from: quay.io/opendatahub/workbench-images
      from:
        kind: DockerImage
        name: 'quay.io/opendatahub/workbench-images@sha256:304d3b2ea846832f27312ef6776064a1bf3797c645b6fea0b292a7ef6416458e'
      generation: 2
      importPolicy:
        importMode: Legacy
      referencePolicy:
        type: Source
status:
  dockerImageRepository: 'image-registry.openshift-image-registry.svc:5000/redhat-ods-applications/runtime-datascience'
  tags:
    - tag: datascience
      items:
        - created: '2025-02-05T10:33:49Z'
          dockerImageReference: 'quay.io/opendatahub/workbench-images@sha256:304d3b2ea846832f27312ef6776064a1bf3797c645b6fea0b292a7ef6416458e'
          image: 'sha256:304d3b2ea846832f27312ef6776064a1bf3797c645b6fea0b292a7ef6416458e'
          generation: 2

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 requested a review from harshad16 February 5, 2025 11:04
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 removed the request for review from dibryant February 5, 2025 11:04
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 5, 2025
@atheo89 atheo89 changed the title Create ImageStream objects for the runtime images [WIP] Create ImageStream objects for the runtime images Feb 5, 2025
@jiridanek
Copy link
Member

‼️ NOTE: Please review the annotation fields carefully 🙂 and provide feedback on whether they meet our requirements. I will update later on with thir inclusion on N and N-1 directories

Since the requirements are to support functionality in notebook-controller, I'll wait to see that part too. Maybe you'd yourself realize in time that something needs to change while writing the notebook-controller part

@atheo89 atheo89 changed the title [WIP] Create ImageStream objects for the runtime images Create ImageStream objects for the runtime images Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants