Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-18930: update Jupyterlab package to 4.2.7 #889

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Feb 6, 2025

Main motivation for this upgrade is the fix of the [1] in the 4.2.7 [2]
release. This should fix the [3] then and the Extension manager can work
as expected again now.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jstourac jstourac self-assigned this Feb 6, 2025
@openshift-ci openshift-ci bot added the size/m label Feb 6, 2025
@jstourac jstourac changed the title Jupyter update RHOAIENG-18930: update Jupyterlab package to 4.2.7 Feb 6, 2025
@openshift-ci openshift-ci bot added size/m and removed size/m labels Feb 6, 2025
@jstourac
Copy link
Member Author

jstourac commented Feb 6, 2025

I ran our common GHA for the Pipfile.lock renewal here: https://github.com/jstourac/notebooks/actions/runs/13174634188/job/36771128083 - let's wait for it to update this branch and see the results then.

@openshift-ci openshift-ci bot added size/xxl and removed size/m labels Feb 6, 2025
@atheo89 atheo89 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 7, 2025
@atheo89
Copy link
Member

atheo89 commented Feb 7, 2025

/lgtm

jstourac and others added 2 commits February 7, 2025 15:21
Main motivation for this upgrade is the fix of the [1] in the 4.2.7 [2]
release. This should fix the [3] then and the Extension manager can work
as expected again now.

* [1] jupyterlab/jupyterlab#17113
* [2] https://github.com/jupyterlab/jupyterlab/releases/tag/v4.2.7
* [3] https://issues.redhat.com/browse/RHOAIENG-18930
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 7, 2025
@jstourac jstourac marked this pull request as ready for review February 7, 2025 16:05
@openshift-ci openshift-ci bot requested review from atheo89 and jiridanek February 7, 2025 16:05
@jstourac
Copy link
Member Author

jstourac commented Feb 7, 2025

/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/images
/override ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/rocm-runtimes-ubi9-e2e-tests
/override ci/prow/runtime-cuda-tensorflow-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtimes-ubi9-e2e-tests

Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images, ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/runtime-cuda-tensorflow-ubi9-python-3-11-pr-image-mirror, ci/prow/runtime-pytorch-ubi9-python-3-11-pr-image-mirror, ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror, ci/prow/runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror, ci/prow/runtimes-ubi9-e2e-tests

In response to this:

/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/images
/override ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/rocm-runtimes-ubi9-e2e-tests
/override ci/prow/runtime-cuda-tensorflow-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtimes-ubi9-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member Author

jstourac commented Feb 7, 2025

This was just rebase, no new actual code added. I checked also on one of the build images that the extension manager is fully operational again now.

Let's get this in so we don't have failing CI test added in #886.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@jstourac: you cannot LGTM your own PR.

In response to this:

This was just rebase, no new actual code added. I checked also on one of the build images that the extension manager is fully operational again now.

Let's get this in so we don't have failing CI test added in #886.

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 7, 2025
@jstourac jstourac added the lgtm label Feb 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0bc66a7 into opendatahub-io:main Feb 7, 2025
34 checks passed
@jstourac jstourac deleted the jupyterUpdate branch February 7, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/xxl tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants