-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.27.0 #900
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: codeflare-machine-account <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We should agree on whether the part of these PRs should be also recently added update of the We can:
Note, there is still question about the manifest updates WRT this, but that has been postponed so far. Otherwise the changes LGTM in general. |
@codeflare-machine-account: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@jstourac Is there anything holding to merge this PR ? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ChughShilpa this was basically just left behind. It would be great to implement change to your workflow so that all the pipenv files are updated per our needs as I mentioned in this comment. @jiridanek workarounded similar upgrade couple of days ago by running our GHA against the original PR branch (#920) and raising it's own PR #921. Anyway, this is now out of sync, I guess the easiest way now is to close this PR and run your workflow again against the latest main branch content. Then we can do workaround the same way as Jiri did yesterday, I presume. |
@ChughShilpa btw is there some tracking jira for this update somewhere? |
🚀 This is an automated Pull Request generated by odh-notebooks-sync.yml workflow.
This PR updates the
Pipfile
to sync with latest Codeflare-SDK release.