Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.27.0 #900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codeflare-machine-account
Copy link
Contributor

🚀 This is an automated Pull Request generated by odh-notebooks-sync.yml workflow.

This PR updates the Pipfile to sync with latest Codeflare-SDK release.

@openshift-ci openshift-ci bot requested review from jstourac and paulovmr February 14, 2025 09:38
Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jstourac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/l label Feb 14, 2025
@jstourac
Copy link
Member

jstourac commented Feb 14, 2025

We should agree on whether the part of these PRs should be also recently added update of the requirement.txt files (see the CI error). Our GHA piplock-renewal.yaml does that for us, but since this change is driven by odh-notebooks-sync.yml, the update of the requirements.txt files isn't incorporated here.

We can:

  1. (manual, one time) merge this as is and fix the inconsistency in a separate PR by us
  2. (manual, one time) take this branch and run our GHA on that in our repository superseding this particular PR
  3. (manual, one time) ask codeflare guys to run the piplock-renewal.yaml workflow on this branch in their repository
  4. ask codeflare guys to update their workflow so that also the requirements.txt files are updated as expected in PRs like this
  5. ask codeflare guys to update their GHA so that they actually utilize our piplock-renewal.yaml workflow in their workflow (this would be preferable over 2 as we would assure the very same env for these updates) - though, I didn't check whether there is some catch
  6. something else?

Note, there is still question about the manifest updates WRT this, but that has been postponed so far.


Otherwise the changes LGTM in general.

Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

@codeflare-machine-account: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror a032e49 link true /test runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror a032e49 link true /test notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror a032e49 link true /test notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/runtimes-ubi9-e2e-tests a032e49 link true /test runtimes-ubi9-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests a032e49 link true /test notebooks-ubi9-e2e-tests
ci/prow/rocm-runtimes-ubi9-e2e-tests a032e49 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/rocm-notebooks-e2e-tests a032e49 link true /test rocm-notebooks-e2e-tests
ci/prow/images a032e49 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ChughShilpa
Copy link

@jstourac Is there anything holding to merge this PR ?

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member

@ChughShilpa this was basically just left behind. It would be great to implement change to your workflow so that all the pipenv files are updated per our needs as I mentioned in this comment. @jiridanek workarounded similar upgrade couple of days ago by running our GHA against the original PR branch (#920) and raising it's own PR #921.

Anyway, this is now out of sync, I guess the easiest way now is to close this PR and run your workflow again against the latest main branch content. Then we can do workaround the same way as Jiri did yesterday, I presume.

@jstourac
Copy link
Member

@ChughShilpa btw is there some tracking jira for this update somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants