Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-20205: update kubeflow-training sdk version to 1.9.0 #905

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Feb 19, 2025

Description

Jira - RHOAIENG-20205
PR to add workflow - opendatahub-io/training-operator#31
Testing here : https://github.com/opendatahub-io/training-notebooks/actions/runs/13436738613/job/37540704640
Results: https://github.com/sutaakar/notebooks/pull/13/files

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/l label Feb 19, 2025
@astefanutti
Copy link

/lgtm

@sutaakar
Copy link

/lgtm

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work,
would it be possible to link, the github workflow and jira for this PR
in the PR description.

Additionally, a question, if we include ~= to version in next updates,
will the automation take that consideration automatically ?

@abhijeet-dhumal
Copy link
Contributor Author

abhijeet-dhumal commented Feb 20, 2025

@jiridanek
Copy link
Member

@abhijeet-dhumal why is this still in draft? can this be reviewed already?

@jiridanek jiridanek changed the title Update kubeflow-training sdk version to 1.9.0 RHOAIENG-20205: update kubeflow-training sdk version to 1.9.0 Feb 20, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 20, 2025
@abhijeet-dhumal
Copy link
Contributor Author

abhijeet-dhumal commented Feb 20, 2025

@jiridanek Here I have triggered another automated PR for the same : #911 🎆
Workflow run used : https://github.com/opendatahub-io/training-notebooks/actions/runs/13437399514/job/37542941508

I will raise another PR to update == to ~= used in sed command here
this change done is to address @harshad16 's suggestion from the thread above ✌️

@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Feb 24, 2025
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the size/l label Feb 24, 2025
@openshift-ci openshift-ci bot added the size/l label Feb 24, 2025
@jiridanek
Copy link
Member

/lgtm

no point hesitating, lets get this in

@openshift-ci openshift-ci bot added the lgtm label Feb 24, 2025
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@abhijeet-dhumal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/codeserver-notebook-e2e-tests 73d5d5a link true /test codeserver-notebook-e2e-tests
ci/prow/rocm-notebooks-e2e-tests 73d5d5a link true /test rocm-notebooks-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests 73d5d5a link true /test notebooks-ubi9-e2e-tests
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror 73d5d5a link true /test notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/images 73d5d5a link true /test images
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror 73d5d5a link true /test notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@abhijeet-dhumal
Copy link
Contributor Author

Updated the workflow to utilise ci/generate_code.sh script and raised PR here : #920
Workflow and results : opendatahub-io/training-operator#31 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants