-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-20205: update kubeflow-training sdk version to 1.9.0 #905
RHOAIENG-20205: update kubeflow-training sdk version to 1.9.0 #905
Conversation
Skipping CI for Draft Pull Request. |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work,
would it be possible to link, the github workflow and jira for this PR
in the PR description.
Additionally, a question, if we include ~=
to version in next updates,
will the automation take that consideration automatically ?
Hey thanks @harshad16 !! Jira - RHOAIENG-20205 |
@abhijeet-dhumal why is this still in draft? can this be reviewed already? |
@jiridanek Here I have triggered another automated PR for the same : #911 🎆 I will raise another PR to update |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm no point hesitating, lets get this in |
@abhijeet-dhumal: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Updated the workflow to utilise ci/generate_code.sh script and raised PR here : #920 ✅ |
Description
Jira - RHOAIENG-20205
PR to add workflow - opendatahub-io/training-operator#31
Testing here : https://github.com/opendatahub-io/training-notebooks/actions/runs/13436738613/job/37540704640
Results: https://github.com/sutaakar/notebooks/pull/13/files
How Has This Been Tested?
Merge criteria: