feat(containers): Remove reliance on chained builds #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
warning: this is only a partial change with 2024a changes included to solicit initial feedback on approach
Commit contains following changes:
Dockerfile
s to to be "self-contained" - not rely on any "build chains" for internal imagesDockerfile
s present in the "build chain" are being combined - long term - we'd expect the following stages:base
,base-<accelerator>
(if applicable),<final>
Dockerfile
file now has a file extension/suffix that indicates CPU or acceleratorLABEL
directives now should be consistent/accuratebase/
directory removed as its no longer relevant/requiredrocm/
related directories removed asROCm
was not actually supported in2024a
wheel
/setuptools
explicitly added toruntime-
imagesPipfile
pytorch
Makefile
targets now containcuda-
prefixENV
directive inDockerfile
now properly uses=
(vs. whitespace)buildinputs
to pull file paths from the terminal layerRelated-to: https://issues.redhat.com/browse/RHOAIENG-19048
How Has This Been Tested?
2024a
branch as seen here:Merge criteria: