[main] Reapply "RHOAIENG-17306, RHOAIENG-17307, RHOAIENG-17308: feat(workbenches): tolerate IPv6 environments in codeserver, jupyterlab and rstudio" #913
Conversation
jiridanek
changed the title
jiridanek
force-pushed
the
jd_refactor_sync
branch
from
6891bae to
261c866
Compare
jiridanek
force-pushed
the
jd_refactor_sync
branch
from
9eca0fe to
5e5b14d
Compare
jiridanek
force-pushed
the
jd_refactor_sync
branch
from
5e5b14d to
8bad27e
Compare
jiridanek
changed the title
| @@ -60,7 +84,7 @@ def _get_cmd(port): | |||
| '--server-working-dir=' + os.getenv('HOME'), | |||
| '--auth-none=1', | |||
| '--www-frame-origin=same', | |||
| #'--www-address=0.0.0.0', | |||
| '--www-address='+ detect_env(), | |||
There was a problem hiding this comment.
| '--www-address='+ detect_env(), | |
| '--www-address=' + detect_env(), |
to be consistent with the other lines... but if this is gonna cause us a conflict during the rebase of the konflux feature branch, we can skip this...
There was a problem hiding this comment.
we should adopt a pre-commit and a python formatter; chasing formatting issues by hand is not very productive
I usually run the intelliJ reformat when I think of it, so the format is kept more or less in decent shape
There was a problem hiding this comment.
good first issue for an intern maybe? 🙂
There was a problem hiding this comment.
maybe, but not @RomanFilip, he needs to do something in Go, and I already have the thing in mind
|
please rebase so the conflicts are resolved, we can then lgtm and merge eventually? |
…workbenches): tolerate IPv6 environments in codeserver, jupyterlab and rstudio""
This is now emitted because we are specifying "" as the listening address, where previously it was "0.0.0.0". ``` "WARNING: The Jupyter server is listening on all IP addresses and not using encryption. This is not recommended.", ```
…vior
Since `localhost` resolves to IPv4 as well as IPv6, it causes
nginx to enable the upstream server rotation.
```
2025/02/22 15:14:06 [error] 21#21: *1 no live upstreams while connecting to upstream, client: 192.168.127.1, server: ${base_url}, request: "GET /codeserver/?folder=/opt/app-root/src HTTP/1.1", upstream: "http://localhost/?folder=/opt/app-root/src", host: "localhost:8888"
```
jiridanek
force-pushed
the
jd_refactor_sync
branch
from
8bad27e to
ce326b0
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/codeserver-notebook-e2e-tests, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rstudio-notebook-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
oh yeah! |
|
/override ci/prow/images |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/images |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 0cf50dd
into
opendatahub-io:main
Getting this PR to be in main
Merge criteria: