Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] NO-JIRA: chore(tests/containers): detect socket for ryuk's use with rootless podman on macOS #914

Merged

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 22, 2025

Brings this PR into main

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from caponetto and dibryant February 22, 2025 10:42
@openshift-ci openshift-ci bot added the size/xl label Feb 22, 2025
@openshift-ci openshift-ci bot added size/xl and removed size/xl labels Feb 22, 2025
@jiridanek jiridanek changed the title NO-JIRA: chore(tests/containers): detect socket for ryuk's use with rootless podman on macOS [main] NO-JIRA: chore(tests/containers): detect socket for ryuk's use with rootless podman on macOS Feb 23, 2025
@openshift-ci openshift-ci bot added size/xl and removed size/xl labels Feb 23, 2025
@jstourac
Copy link
Member

/override ci/prow/images

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/override ci/prow/images

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

thanks,
/approve

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ff24dc0 into opendatahub-io:main Feb 25, 2025
7 checks passed
@jiridanek jiridanek deleted the jd_refactor_sync_2 branch February 25, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants