Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #887: add fixtures to skip test if it's not jupyterlab/codeserver/rstudio image #918

Merged
merged 21 commits into from
Feb 25, 2025

Conversation

RomanFilip
Copy link
Contributor

@RomanFilip RomanFilip commented Feb 24, 2025

added fixtures to skip pytests tests if there is not rstudio image

Description

delete functions skip_if_not_rstudio_image(image) and replace it with fixtures

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from caponetto and jstourac February 24, 2025 09:47
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

Hi @RomanFilip. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

added skip tests fixture

please follow the commit message format, look in previous commits in the repo

@jiridanek
Copy link
Member

/ok-to-test

@RomanFilip RomanFilip changed the title added skip tests fixture Add fixtures to skip tests Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@RomanFilip RomanFilip changed the title Add fixtures to skip tests ISSUE:#887 Add fixtures to skip test if it's not rstudio image Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@jiridanek jiridanek changed the title ISSUE:#887 Add fixtures to skip test if it's not rstudio image ISSUE #887: add fixtures to skip test if it's not rstudio image Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@jiridanek jiridanek changed the title ISSUE #887: add fixtures to skip test if it's not rstudio image ISSUE #887: add fixtures to skip test if it's not jupyterlab/codeserver/rstudio image Feb 24, 2025
@openshift-ci openshift-ci bot added size/l and removed size/l labels Feb 24, 2025
@jiridanek
Copy link
Member

/lgtm
/override ci/prow/images
not applicable

@jiridanek jiridanek added the lgtm label Feb 24, 2025
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/lgtm
/override ci/prow/images
not applicable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@RomanFilip: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images d31958c link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek merged commit 54ca634 into opendatahub-io:main Feb 25, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants