Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #631: lowercase the image repository name in github actions #919

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

RomanFilip
Copy link
Contributor

@RomanFilip RomanFilip commented Feb 24, 2025

Fixes #631

Description

Error: unable to parse value provided [ghcr.io/RomanFilip/notebooks-fork/workbench-images/build-cache] to --cache-to: invalid repo "ghcr.io/RomanFilip/notebooks-fork/workbench-images/build-cache": must contain registry and repository: invalid reference format: repository name must be lowercase

https://github.com/RomanFilip/notebooks-fork/actions/runs/13499383840/job/37713825404#step:17:95

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

Hi @RomanFilip. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Feb 24, 2025
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cbea.ms/git-commit/#imperative

A properly formed Git commit subject line should always be able to complete the following sentence:

If applied, this commit will

Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Feb 24, 2025
@RomanFilip RomanFilip changed the title ISSUE #631: transforming branch name into image label while running CI in lowercase ISSUE #631: lowercase repository name in github actions Feb 24, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Feb 24, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Feb 24, 2025
@jiridanek
Copy link
Member

jiridanek commented Feb 24, 2025

/override ci/prow/images
not applicable

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not applicable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Feb 24, 2025
@jiridanek jiridanek changed the title ISSUE #631: lowercase repository name in github actions ISSUE #631: lowercase the image repository name in github actions Feb 24, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Feb 24, 2025
@jiridanek jiridanek merged commit 1703ea2 into opendatahub-io:main Feb 24, 2025
6 of 8 checks passed
@RomanFilip RomanFilip deleted the lowercase-user branch February 24, 2025 15:57
- name: downcase IMAGE_REGISTRY and CACHE
run: |
echo "IMAGE_REGISTRY=${IMAGE_REGISTRY,,}" >>${GITHUB_ENV}
echo "CACHE=${CACHE,,}" >>${GITHUB_ENV}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, it would be nice to use some POSIX way, see e.g.: https://stackoverflow.com/questions/2264428/how-to-convert-a-string-to-lower-case-in-bash . But yeah... no need to update this since it's been merged already and works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When transforming branch name into image label while running CI checks, take care not to create invalid label
3 participants