-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-18124] Add Workload Metrics Sanity tests #3767
base: main
Are you sure you want to change the base?
[RHOAIENG-18124] Add Workload Metrics Sanity tests #3767
Conversation
Skipping CI for Draft Pull Request. |
6967da6
to
9885482
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3767 +/- ##
=======================================
Coverage 84.63% 84.64%
=======================================
Files 1515 1515
Lines 35100 35100
Branches 9814 9814
=======================================
+ Hits 29707 29709 +2
+ Misses 5393 5391 -2 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
24138c7
to
484ffed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to use retryableBefore
instead of before
in your tests.
Also, no need to specify running with ODS-CI - we do not use it to run Cypress.
...ss/cypress/tests/e2e/distributedWorkloadMetrics/testWorkloadMetricsDefaultPageContents.cy.ts
Outdated
Show resolved
Hide resolved
2381c69
to
a11acb1
Compare
93ac3e4
to
7e432e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@antowaddle Can you review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Srihari1192 Thanks for the contribution, really appreciate new contributions to the framework. I've added some comments, can you review them please? Additionally, can i ask that you review #3614 and use this format on your PR also.
frontend/src/__tests__/cypress/cypress/pages/distributedWorkloads.ts
Outdated
Show resolved
Hide resolved
...ss/cypress/tests/e2e/distributedWorkloadMetrics/testWorkloadMetricsDefaultPageContents.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/utils/oc_commands/distributedWorkloads.ts
Show resolved
Hide resolved
7e432e4
to
092dd5f
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
092dd5f
to
c982bbd
Compare
c982bbd
to
3804c6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
// Get the tooltip element and extract its text | ||
return cy | ||
.get("[style*='fill: var(--pf-v6-chart-tooltip--Fill']") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we create a testID for the tooltip? We typically do not use patternfly locators in our test as they can change which will break the test and require maintenance.
}) | ||
.then(() => { | ||
cy.log('Creating Namespace ${projectName}'); | ||
createOpenShiftProject(projectName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use createCleanProject here instead? Currently this test will fail if the project already exists on the cluster, createCleanProject will do a cleanup if the test exists.
https://issues.redhat.com/browse/RHOAIENG-18124
Description
How Has This Been Tested?
This change will include workloadmetrics Sanity tests, tested in local against rhoai nightly build

Test Impact
None - this is a test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main