-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node 20 #3783
base: main
Are you sure you want to change the base?
Upgrade to Node 20 #3783
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3783 +/- ##
==========================================
+ Coverage 84.63% 84.64% +0.01%
==========================================
Files 1515 1515
Lines 35100 35100
Branches 9814 9814
==========================================
+ Hits 29707 29712 +5
+ Misses 5393 5388 -5 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
2ea305f
to
03a3753
Compare
@christianvogt @andrewballantyne weird that there's still a |
18.x is likely still here because it's required by branch protections... I could swap it to 20.x but it seems I might open up every other PR to not needing their tests 🤔 |
@@ -7,7 +7,7 @@ ARG CYPRESS_CACHE=$USER_HOME/.cypress-cache | |||
ARG CHROME=https://dl.google.com/linux/direct/google-chrome-stable_current_x86_64.rpm | |||
ARG OCP_CLI=https://mirror.openshift.com/pub/openshift-v4/clients/ocp/stable/openshift-client-linux.tar.gz | |||
ARG NVM_INSTALLER=https://raw.githubusercontent.com/creationix/nvm/v0.39.7/install.sh | |||
ARG NODE_VERSION=v20.15.0 | |||
ARG NODE_VERSION=v20.18.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we always built our images with 20? lol... interesting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @manosnoam suggested this a long time ago, I cannot recall the conversation but we agreed on having ci tests on Node 20.
Ok, tested in a current clsuter, everything seems to be working just fine, image is |
Description
Upgrade dashboard and CI/CD to Node 22
quay.io/lferrnan/odh-dashboard:rhoaieng-7374
How Has This Been Tested?
nvm
quay.io/lferrnan/odh-dashboard:rhoaieng-7374
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main