Fine tune taxonomy #3785
Fine tune taxonomy #3785
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3785 +/- ##
==========================================
- Coverage 84.63% 84.59% -0.05%
==========================================
Files 1515 1517 +2
Lines 35100 35170 +70
Branches 9814 9828 +14
==========================================
+ Hits 29707 29752 +45
- Misses 5393 5418 +25
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pnaik1
force-pushed
the
rhoaieng-19173
branch
4 times, most recently
from
b342eba to
8cf2323
Compare
pnaik1
force-pushed
the
rhoaieng-19173
branch
from
8cf2323 to
e04ff59
Compare
|
Updated the pr with removing the default value of |
| @@ -110,8 +114,29 @@ export const fineTunedModelDetailsSchema = z.object({ | |||
| modelStorageLocation: z.string(), | |||
| }); | |||
|
|
|||
| export const fineTuneTaxonomySchema = z.object({ | |||
| url: z.string().url().min(1, 'Taxonomy Git URL is required'), | |||
There was a problem hiding this comment.
Should we have a regex expression here to catch URLs that do not have github in it? It seems that any link would work here.
There was a problem hiding this comment.
Yes, we can have a regex expression here, but I doubt the Git URL having a different format other than github (ex: gitlab and bitbucket) . We can probably use a regex expression to catch URLs that don't have .git at the end?? @Gkrumbach07 are we only supporting github url??
There was a problem hiding this comment.
any repo would work. not just Github
frontend/src/pages/pipelines/global/modelCustomization/FineTuneTaxonomySection.tsx
Outdated
Show resolved
Hide resolved
| data-testid={FineTunePageSections.TAXONOMY_DETAILS} | ||
| title={fineTunePageSectionTitles[FineTunePageSections.TAXONOMY_DETAILS]} | ||
| > | ||
| {/* TODO: add link to taxonomy */} |
There was a problem hiding this comment.
can you link the microcopy jira: https://issues.redhat.com/browse/RHOAIENG-19187
| @@ -40,6 +40,14 @@ const ModelCustomizationForm: React.FC = () => { | |||
| version: 'myModel-v0.0.2', | |||
| inputStorageLocationUri: searchParams.get(BASE_MODEL_INPUT_STORAGE_LOCATION_URI_KEY) ?? '', | |||
| }, | |||
| taxonomy: { | |||
| url: '', | |||
There was a problem hiding this comment.
where are you presetting the default url from the pipeline. we will need a
useEffect(() => {
if(ilabPipelineLoaded) {
setData("taxonomy", {...data.taxonomy, url: getPipelineParamDefault(ilabPipeline, "sdg_repo_url")})
}
})There was a problem hiding this comment.
I have done it earlier, but changed later on according to the new api changes (no default value) https://docs.google.com/spreadsheets/d/16G5r6tV1TsgKbk-WoRoe0ZW9LsCWp093rnVDfySM33s/edit?gid=1780396156#gid=1780396156
frontend/src/pages/pipelines/global/modelCustomization/FineTuneTaxonomySection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/modelCustomization/FineTuneTaxonomySection.tsx
Outdated
Show resolved
Hide resolved
pnaik1
force-pushed
the
rhoaieng-19173
branch
from
e04ff59 to
cb1becf
Compare
| @@ -23,11 +24,10 @@ type FineTunePageFooterProps = { | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars -- TODO remove this line when start using `data` | |||
There was a problem hiding this comment.
We should remove this comment now.
https://issues.redhat.com/browse/RHOAIENG-19173
Description
Added taxonomy section
How Has This Been Tested?
Test whether the submit button is disabled/enabled between sshkey type and username and token type
Test whether submitting it will create secrets
Test Impact
added unit test and cypress test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main