Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for hardware profiles #3787

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Gkrumbach07
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-17224

Description

follows: https://docs.google.com/document/d/1VtvU2gOhNU_aW0xol0SquWGlSGvh2o_G7jgpQzGwDa4/edit?tab=t.0#heading=h.9i6jzposf7xi
Adds the the following

  • New useMigratedHardwareProfiles
    • creates migration/fake hardware profiles from...
      • accelerator profiles
        • creates 2: one for notebooks, one for serving
        • notebooks gets notebook only toleration if enabled
      • container size from dashboard config
        • notebooks and serving
        • notebooks gets notebook only toleration if enabled
    • returns all fake and real hardware profiles
    • also returns a way to get a MigrationAction
      • this has info and callbacks to delete the source and give details for the migrated
  • introduces visible in concept for hardware profiles
    • new field in manage page
    • is used to hide/show certain hardware profiles is certain areas
    • has a hook to abstract it for use
    • new column in table
  • makes maxCount optional in CRD
  • adds labels on hardware profile table to indicate there are translated profiles
  • adds warnings on delete for translated profiles
    • on delete, it will delete the source
  • adds warnings on edit of translated resource
    • will delete source
    • will create new hardware profile
    • will also create additional profiles if the source had more than dependent like accelerator profiles

How Has This Been Tested?

  1. create hardware profiles, accelerator profiles, and populate dashboard config with notebook and model serving container sizes
  2. try editing and saving both types of translated hardware profiles
  3. try deleting both types
  4. edit visible in and make sure it is reflected in notebooks areas and serving runtime areas

Test Impact

added units tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

hide accelerator profile nav when using hardware profiles

fix tests

added tests and small bug fixes

Add hardware profile visibility and migration improvements

- Add optional maxCount for identifiers
- Implement hardware profile visibility section
- Enhance migration support for hardware profiles
- Update migration utilities and types
- Add migration action and tooltip components
- Modify hardware profile table and form to support new features
@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti February 20, 2025 22:52
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gkrumbach07. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member Author

Some Images @vconzola @kaedward

Table details
Screenshot 2025-02-20 at 5 18 46 PM
Screenshot 2025-02-20 at 5 18 39 PM
Screenshot 2025-02-20 at 5 17 52 PM

** New visibility param**
Screenshot 2025-02-20 at 5 18 32 PM
Screenshot 2025-02-20 at 5 20 16 PM
Screenshot 2025-02-20 at 5 20 07 PM
Screenshot 2025-02-20 at 5 19 59 PM

Edit warnings
Screenshot 2025-02-20 at 5 19 39 PM
Screenshot 2025-02-20 at 5 19 27 PM

Delete warnings
Screenshot 2025-02-20 at 5 19 07 PM
Screenshot 2025-02-20 at 5 18 53 PM

@pnaik1
Copy link
Contributor

pnaik1 commented Feb 24, 2025

@Gkrumbach07 , Do we need alert message when we duplicating a simulted hardwareprofiles?

Screenshot 2025-02-24 at 6 24 37 PM

…agement

- Update HardwareProfileFormSection to use new podSpecOptionsState
- Modify HardwareProfileSelect to support more flexible configuration
- Enhance HardwareProfileDetailsPopover to handle existing settings
- Improve validation and resource handling in hardware profile components
- Update types and utility functions to support new hardware profile approach
- Remove deprecated hardware profiles hook
@pnaik1
Copy link
Contributor

pnaik1 commented Feb 25, 2025

tested all the functionality works well except
the deletion of simulated hardwareProfiles takes more time to reflect the changes in the HardwareProfile table

- Update config route to support cache control and force refresh
- Modify migration tooltip to improve user experience
- Remove out-of-the-box (OOTB) hardware profile specific logic
- Update hardware profile table row and migration utilities
- Add tooltips and help text for node resource configuration
- Improve dashboard config service to support force refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants