Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Cypress - further e2e stabilisation #3788

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Feb 21, 2025

https://issues.redhat.com/browse/RHOAIENG-20106

Description

How Has This Been Tested?

  • Multiple times on the Jenkins pipelines, we're down to 1 failure now (previously 7)
    image

Test Impact

  • None - this PR stabilises e2e Tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 21, 2025
Copy link
Contributor

openshift-ci bot commented Feb 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from antowaddle. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (6ded983) to head (d35ea5e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3788      +/-   ##
==========================================
- Coverage   84.71%   84.70%   -0.02%     
==========================================
  Files        1512     1512              
  Lines       34956    34956              
  Branches     9786     9786              
==========================================
- Hits        29613    29609       -4     
- Misses       5343     5347       +4     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ded983...d35ea5e. Read the comment docs.

@antowaddle antowaddle marked this pull request as ready for review February 21, 2025 15:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Feb 21, 2025
@antowaddle
Copy link
Contributor Author

/cc @manosnoam @ConorOM1

@openshift-ci openshift-ci bot requested review from ConorOM1 and manosnoam February 21, 2025 16:16
@antowaddle antowaddle changed the title Cypress - further e2e stabilisation WIP - Cypress - further e2e stabilisation Feb 24, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 24, 2025
@antowaddle
Copy link
Contributor Author

@manosnoam @ConorOM1 I'm setting this as Work in Progress again, we saw passing results over the weekend without this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant