Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear status message for models with disabled NIM #3791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LinoyBitan1
Copy link
Contributor

@LinoyBitan1 LinoyBitan1 commented Feb 23, 2025

JIRA - https://issues.redhat.com/browse/NVPE-149

Description

This PR ensures a more readable and clear status message for Inference Service models in "pending" or "failed" states when NVIDIA NIM is disabled. Previously, a generic and unclear error message was displayed in such cases.

Before the fix:

  • The status message displayed a generic error for models that failed to load when NIM was disabled.
    before149

After the fix:

  • The status message now clearly indicates that the failure or pending status is due to NIM being disabled.
    image

How Has This Been Tested?

Tested locally.

Test Impact

  1. Install RHOAI 2.17
  2. Go to the explore tab then click NVIDIA NIM card
  3. Provide a valid API key and click submit
  4. Create a new project and new NIM model
  5. Disable NIM by changing API key in nvidia-nim-access Secret
  6. Open the model list in your project in RHOAI
  7. Ensure that the status message reflects the relevant error -NVIDIA NIM is currently not enabled when the model is pending or failed.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 23, 2025
Copy link
Contributor

openshift-ci bot commented Feb 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Feb 23, 2025
Copy link
Contributor

openshift-ci bot commented Feb 23, 2025

Hi @LinoyBitan1. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (6ded983) to head (3850609).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...end/src/pages/modelServing/screens/global/utils.ts 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3791      +/-   ##
==========================================
- Coverage   84.71%   84.64%   -0.08%     
==========================================
  Files        1512     1515       +3     
  Lines       34956    35107     +151     
  Branches     9786     9818      +32     
==========================================
+ Hits        29613    29716     +103     
- Misses       5343     5391      +48     
Files with missing lines Coverage Δ
...lServing/screens/global/InferenceServiceStatus.tsx 86.36% <100.00%> (+0.64%) ⬆️
...erving/screens/global/InferenceServiceTableRow.tsx 100.00% <ø> (ø)
...end/src/pages/modelServing/screens/global/utils.ts 97.14% <87.50%> (-2.86%) ⬇️

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ded983...3850609. Read the comment docs.

@LinoyBitan1 LinoyBitan1 force-pushed the status-message-nim-not-enabled branch from 65defee to b61506e Compare February 25, 2025 15:04
@LinoyBitan1 LinoyBitan1 force-pushed the status-message-nim-not-enabled branch from b61506e to 3850609 Compare February 25, 2025 15:08
@LinoyBitan1 LinoyBitan1 marked this pull request as ready for review February 25, 2025 15:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Feb 25, 2025
@emilys314
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants