-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clear status message for models with disabled NIM #3791
base: main
Are you sure you want to change the base?
Add clear status message for models with disabled NIM #3791
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @LinoyBitan1. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3791 +/- ##
==========================================
- Coverage 84.71% 84.64% -0.08%
==========================================
Files 1512 1515 +3
Lines 34956 35107 +151
Branches 9786 9818 +32
==========================================
+ Hits 29613 29716 +103
- Misses 5343 5391 +48
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
65defee
to
b61506e
Compare
b61506e
to
3850609
Compare
/ok-to-test |
JIRA - https://issues.redhat.com/browse/NVPE-149
Description
This PR ensures a more readable and clear status message for Inference Service models in "pending" or "failed" states when NVIDIA NIM is disabled. Previously, a generic and unclear error message was displayed in such cases.
Before the fix:
After the fix:
How Has This Been Tested?
Tested locally.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main