Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(19957): set rhoai manifest disableModelCatalog flag false #3800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gitdallas
Copy link
Contributor

@gitdallas gitdallas commented Feb 24, 2025

closes: https://issues.redhat.com/browse/RHOAIENG-19957

Description

set disableModelCatalog feature flag to false for rhoai manifest only

How Has This Been Tested?

doesn't affect odh clusters
image

tested on rhoai cluster and don't see model catalog
image

Test Impact

none

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (9b6b7a6) to head (4520bc2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3800      +/-   ##
==========================================
+ Coverage   84.63%   84.64%   +0.01%     
==========================================
  Files        1515     1515              
  Lines       35100    35100              
  Branches     9814     9814              
==========================================
+ Hits        29707    29711       +4     
+ Misses       5393     5389       -4     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6b7a6...4520bc2. Read the comment docs.

@gitdallas gitdallas changed the title [WIP] chore(19957): set rhoai manifest disableModelCatalog flag false chore(19957): set rhoai manifest disableModelCatalog flag false Feb 25, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Feb 25, 2025
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manaswinidas
Once this PR has been reviewed and has the lgtm label, please assign mturley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gitdallas gitdallas requested a review from mturley February 26, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants