Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] added ilab form basic params #3805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Feb 26, 2025

Description

Added run type and hyperparameter fields
Screenshot 2025-02-25 at 7 52 43 PM

How Has This Been Tested?

Visually. Some testing in cypress and unit test files

Test Impact

Some testing in cypress and unit test files

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from lucferbux and ppadti February 26, 2025 00:53
Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsun19
Copy link
Contributor Author

rsun19 commented Feb 26, 2025

these are the mappings; i am not 100% sure they are correct

export enum HyperparameterFields {
  SDG_SAMPLE_SIZE = 'sdg_sample_size',
  SDG_SCALE_FACTOR = 'sdg_scale_factor',
  MAXIMUM_TOKENS_PER_ACCELERATOR = 'train_max_batch_len',
  TRAINING_WORKERS = 'train_nnodes',
  TRAIN_NUM_EPOCHS_PHASE_1 = 'train_num_epochs_phase_1',
  TRAIN_NUM_EPOCHS_PHASE_2 = 'train_num_epochs_phase_2',
  BATCH_SIZE_PHASE_1 = 'train_effective_batch_size_phase_1',
  BATCH_SIZE_PHASE_2 = 'train_effective_batch_size_phase_2',
  LEARNING_RATE_PHASE_1 = 'train_learning_rate_phase_1',
  LEARNING_RATE_PHASE_2 = 'train_learning_rate_phase_2',
  WARMUP_STEPS_PHASE_1 = 'train_num_warmup_steps_phase_1',
  WARMUP_STEPS_PHASE_2 = 'train_num_warmup_steps_phase_2',
  MAXIMUM_BATCH_LENGTH = 'sdg_max_batch_len',
  TRAINING_SEED = 'train_seed',
  QUESTION_ANSWER_PAIRS = 'final_eval_few_shots',
  EVALUATION_WORKERS = 'final_eval_max_workers',
  EVALUATION_BATCH_SIZE = 'final_eval_batch_size',
}

export const HYPERPARAMETER_DISPLAY_NAMES: Record<HyperparameterFields, string> = {
  [HyperparameterFields.SDG_SCALE_FACTOR]: 'SDG scale factor',
  [HyperparameterFields.MAXIMUM_TOKENS_PER_ACCELERATOR]: 'Maximum tokens per accelerator',
  [HyperparameterFields.SDG_SAMPLE_SIZE]: 'SDG skill recipe sample size',
  [HyperparameterFields.TRAINING_WORKERS]: 'Training workers',
  [HyperparameterFields.TRAIN_NUM_EPOCHS_PHASE_1]: 'Epochs (phase 1)',
  [HyperparameterFields.TRAIN_NUM_EPOCHS_PHASE_2]: 'Epochs (phase 2)',
  [HyperparameterFields.BATCH_SIZE_PHASE_1]: 'Batch size (phase 1)',
  [HyperparameterFields.BATCH_SIZE_PHASE_2]: 'Batch size (phase 2)',
  [HyperparameterFields.LEARNING_RATE_PHASE_1]: 'Learning rate (phase 1)',
  [HyperparameterFields.LEARNING_RATE_PHASE_2]: 'Learning rate (phase 2)',
  [HyperparameterFields.WARMUP_STEPS_PHASE_1]: 'Warmup steps (phase 1)',
  [HyperparameterFields.WARMUP_STEPS_PHASE_2]: 'Warmup steps (phase 2)',
  [HyperparameterFields.MAXIMUM_BATCH_LENGTH]: 'Maximum batch length',
  [HyperparameterFields.TRAINING_SEED]: 'Training seed',
  [HyperparameterFields.QUESTION_ANSWER_PAIRS]: 'Question-answer pairs',
  [HyperparameterFields.EVALUATION_WORKERS]: 'Evaluation workers',
  [HyperparameterFields.EVALUATION_BATCH_SIZE]: 'Evaluation batch size',
};

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 65.53191% with 81 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (e163f5f) to head (ea5496d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...s/global/modelCustomization/FineTunePageFooter.tsx 12.50% 35 Missing ⚠️
...global/modelCustomization/HyperparameterFields.tsx 62.79% 16 Missing ⚠️
...rparameterFields/HyperparameterLongNumberField.tsx 54.54% 10 Missing ⚠️
...rparameterFields/HyperparameterEvaluationField.tsx 57.14% 9 Missing ⚠️
...obal/modelCustomization/ModelCustomizationForm.tsx 80.00% 4 Missing ⚠️
...yperparameterFields/HyperparameterNumericField.tsx 81.25% 3 Missing ⚠️
...pelines/global/modelCustomization/FineTunePage.tsx 80.00% 3 Missing ⚠️
...rm/modelCustomizationFormSchema/validationUtils.ts 94.73% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (65.53%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #3805    +/-   ##
========================================
  Coverage   84.63%   84.64%            
========================================
  Files        1515     1521     +6     
  Lines       35100    35318   +218     
  Branches     9814     9898    +84     
========================================
+ Hits        29707    29894   +187     
- Misses       5393     5424    +31     
Files with missing lines Coverage Δ
...oncepts/pipelines/content/createRun/submitUtils.ts 90.90% <100.00%> (ø)
...mizationForm/modelCustomizationFormSchema/types.ts 100.00% <100.00%> (ø)
...pages/pipelines/global/modelCustomization/const.ts 100.00% <100.00%> (ø)
...rm/modelCustomizationFormSchema/validationUtils.ts 58.33% <94.73%> (+23.95%) ⬆️
...yperparameterFields/HyperparameterNumericField.tsx 81.25% <81.25%> (ø)
...pelines/global/modelCustomization/FineTunePage.tsx 83.33% <80.00%> (-16.67%) ⬇️
...obal/modelCustomization/ModelCustomizationForm.tsx 87.09% <80.00%> (+5.84%) ⬆️
...rparameterFields/HyperparameterEvaluationField.tsx 57.14% <57.14%> (ø)
...rparameterFields/HyperparameterLongNumberField.tsx 54.54% <54.54%> (ø)
...global/modelCustomization/HyperparameterFields.tsx 62.79% <62.79%> (ø)
... and 1 more

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e163f5f...ea5496d. Read the comment docs.

@rsun19 rsun19 changed the title added ilab form basic params [wip] added ilab form basic params Feb 26, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant