Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Cypress e2e Tests - Custom resource and Single Move Serving tests from quarantine #3806

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Feb 26, 2025

https://issues.redhat.com/browse/RHOAIENG-20207

Description

How Has This Been Tested?

Test Impact

  • None

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

…the Data Science Project List View and Create a custom resource Quickstart by using Dashboard CRDs
@openshift-ci openshift-ci bot requested review from mturley and pnaik1 February 26, 2025 10:56
Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from antowaddle. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (a05d232) to head (2ec0a4a).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3806   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files        1517     1517           
  Lines       35134    35134           
  Branches     9836     9836           
=======================================
+ Hits        29748    29751    +3     
+ Misses       5386     5383    -3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05d232...2ec0a4a. Read the comment docs.

@antowaddle antowaddle changed the title Cypress e2e Tests - Remove Juypter and Custom resource tests from quarantine WIP Cypress e2e Tests - Remove Juypter and Custom resource tests from quarantine Feb 26, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 26, 2025
@antowaddle antowaddle changed the title WIP Cypress e2e Tests - Remove Juypter and Custom resource tests from quarantine WIP Cypress e2e Tests - Custom resource and Single Move Serving tests from quarantine Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant