New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place synsets inside ConceptODR #38

Open

DavidLeoni opened this issue Mar 24, 2016 · 0 comments

Labels

0.11.x enhancement KnowledgeService NlpService

Member

DavidLeoni commented Mar 24, 2016

Synsets (and thus synonyms) are currently not placed inside disiclient's ConceptODR name, as one would expect.

Looking at the actual implementation, this happens:

disiclient readConcepts calls many readConcept, which call sweb client readConcept
disiclient readConcept just reads sweb concept and converts it to ConceptODR, without fetching synonims

Also, in sweb 3.0.2-SNAPSHOT

there is no readSynsetS (watch the plural) api
there is no readConceptS (watch the plural) api
there is not even a readConcept that also provides synsets at the same time

so currently synonyms can only be placed inside a SemText Meaning by picking them from NLP results.

To improve the situation without changing sweb we might implement disi client readConcept by calling directly readSynset.

DavidLeoni added enhancement 0.11.x KnowledgeService NlpService labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment