Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converter removes parameters of odsComponentStageRolloutOpenShiftDeployment #6

Open
tbugfinder opened this issue Mar 25, 2022 · 0 comments

Comments

@tbugfinder
Copy link

func replaceComponentStageRolloutMultiLine(content string) (string, bool) {
re := regexp.MustCompile(`(?ms)odsComponentStageRolloutOpenShiftDeployment\((context, \[\n?.*)]\)$`)
return re.ReplaceAllString(content, "odsComponentStageRolloutOpenShiftDeployment(context)"), re.Match([]byte(content))
}
func replaceComponentStageRolloutSingleLine(content string) (string, bool) {
re := regexp.MustCompile(`odsComponentStageRolloutOpenShiftDeployment(.*)`)
return re.ReplaceAllString(content, "odsComponentStageRolloutOpenShiftDeployment(context)"), re.Match([]byte(content))
}

I'm wondering about this implementation as there are valid parameters and the Upgrade docs do not refer to this kind of change.

https://www.opendevstack.org/ods-documentation/opendevstack/4.x/update-guides/4x.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant