New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ods-deploy-helm release-name is component not the chart-name #4

Open

henrjk opened this issue Nov 29, 2022 · 1 comment

Labels

bug

Member

henrjk commented Nov 29, 2022

Currently the documentation at https://github.com/opendevstack/ods-pipeline/blob/master/docs/tasks/ods-deploy-helm.adoc states: "The Helm release name. If empty, the release name is simply the name of the chart."

However it actually defaults to the component name see https://github.com/opendevstack/ods-pipeline/blob/01a67e7a6a1dcb98045e73bbefc939cb854084c9/cmd/deploy-helm/steps.go#L86-L90

To me what is documented makes more sense but it should be consistent.

michaelsauter added the bug label

Member

michaelsauter commented Sep 29, 2023

Transferring as a consequence of opendevstack/ods-pipeline#722.

michaelsauter transferred this issue from opendevstack/ods-pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment