Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce successful pipeline run for parent repo as well #692

Open
michaelsauter opened this issue May 16, 2023 · 0 comments
Open

Enforce successful pipeline run for parent repo as well #692

michaelsauter opened this issue May 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@michaelsauter
Copy link
Member

Right now, when an artifact-source is configured for the pipeline of an umbrella repo, it is ensured that all configured subrepos have a successful pipeline run for the checked out commit. This ensures that e.g. image promotion to the target namespace works as expected.

What is currently not implemented is a similar check for the umbrella repo itself. For an umbrella repo this may not be crucial, but for the case where there is only a single repo, this feature is important. When there is no umbrella repo, merges must be done using fast-forward in order not to loose artifacts during promotion. Therefore, ODS Pipeline should check for this to avoid surprises.

As a consequence, Git merge operations which result in promotion must be done using fast-forward. I think this is fine, as that is the safest way to promote.

A further consequence is that the example project doc must be adjusted as there must be a pipeline run pushing artifacts into the Nexus dev repo, otherwise going to QA does not work. This is also fine as it enforces a good workflow (opening a PR to go to QA).

@michaelsauter michaelsauter added the enhancement New feature or request label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant