Cleanup Jenkins agent image labels

[michaelsauter]

We use the labels as specified by RedHat. I think they are only useful for their build service and make no sense for us at all. I think we should just remove them.

While we are at it, we could remove the maintainer label too.

Thoughts @faust2199 @gerardcl @henrjk @oalyman?

[gerardcl]

Agree! cleanup is always welcome 👍 I think the maintainer removal has already been done at some places indeed..

[henrjk]

@michaelsauter: Do you mean for example the label defined at

ods-quickstarters/common/jenkins-agents/golang/ocp-config/bc.yml

Line 25 in 883607e

app: jenkins-agent-golang

[michaelsauter]

Sorry for the confusion, I meant the image labels in the Dockerfile, like https://github.com/opendevstack/ods-quickstarters/blob/master/common/jenkins-agents/maven/docker/Dockerfile.ubi8#L3-L10.

[henrjk]

Thanks for the clarification. I am for removing Labels only useful to the RedHat builder.

To me it appeared that architecture and name might be useful to keep.

However I looked what standard labels might be defined and ended up at https://github.com/opencontainers/image-spec/blob/master/annotations.md#pre-defined-annotation-keys
I assumed that LABEL statement would become an annotation as per the OCI image format.

As architecture is not mentioned anywhere in the annotations it may belong more into the realm of the runtime-spec (https://github.com/opencontainers/runtime-spec).

Any thoughts about platform in particular?

[michaelsauter]

Hmm, no particular thoughts around platform.

I think the way I stated it originally was probably too drastic. We can keep architecture and name. I also found https://bugzilla.redhat.com/show_bug.cgi?id=1334605, which unfortunately leads to a 404, but the io.k8s labels could be useful too.

Maybe we start by unifying the labels and remove all com.redhat ones?